Skip to content

Conversation

@jeremy
Copy link

@jeremy jeremy commented Jan 29, 2025

Better to float on the future with negligible risk of incompatibility rather than contribute to dependency hell.

@ryankopf
Copy link

Seems like a no-brainer to me.

@joe-sharp
Copy link

+1 any chance we can get this merged and get a 1.3.2 released? This is holding up Ruby 3.4 adoption and we are 6 months or so till Ruby 3.5 is released.

@mathieujobin
Copy link

can you lock it < 3.5 for now, this will force someone for updating the test suite...

we want to see the tests running on 3.4 and I am surprise there is not a changelog on this project..

can you also bump the version like the previous commit ? 2b03a42

Thanks

@joe-sharp
Copy link

can you lock it < 3.5 for now, this will force someone for updating the test suite...

we want to see the tests running on 3.4 and I am surprise there is not a changelog on this project..

can you also bump the version like the previous commit ? 2b03a42

Thanks

@mathieujobin I opened a separate PR with your request #9 in case @jeremy wants to keep this one and make a case for his change.

@mathieujobin
Copy link

Thanks for your contribution. Please reopen if you still think its necessary.

https://github.com/payrollhero/dynamic_form/releases/tag/v1.3.2 released and going to be available from rubygems shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants