do not use https://github.com/start-jsk/rtmros_common/pull/1095 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default-controller returens list of possible controllers: https://github.com/jsk-ros-pkg/jsk_robot/blob/c161b6a87fa00a29909833bb1250c5ee96e42de6/jsk_baxter_robot/baxtereus/baxter-interface.l#L59-L63
pazeshun
requested changes
May 4, 2020
| ;; so queue size of joint_states should be two. | ||
| ;; https://github.com/jsk-ros-pkg/jsk_pr2eus/blob/0.3.13/pr2eus/robot-interface.l#L120 | ||
| (send-super* :init :joint-states-queue-size 2 :robot robot :type | ||
| (if on-gazebo-ros-control :gazebo-ros-controller :default-controller) |
There was a problem hiding this comment.
これだと、Gazeboでは以下のように:default-controllerを明示的に指定した場合に送れなくなるのですが、僕自身:default-controllerを明示的に指定したことはあまりないので、大丈夫だとは思います。
3.irteusgl$ send *ri* :angle-vector (send *hironxjsk* :reset-manip-pose) 1000 :default-controller
;; controller-type: :default-controller not foundnil
pazeshun
approved these changes
May 4, 2020
pazeshun
added a commit
that referenced
this pull request
Jun 26, 2020
…eal HIRONXJSK #4 (comment) includes misunderstanding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small fix for code cleanup;
default-controller returens list of possible controllers: https://github.com/jsk-ros-pkg/jsk_robot/blob/c161b6a87fa00a29909833bb1250c5ee96e42de6/jsk_baxter_robot/baxtereus/baxter-interface.l#L59-L63,
If we follow this gudieline, I think having
(:default-controllrand(:gazebo-ros-controllerwould be ok.