Fix Discriminator with Inline Bundling #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix inline bundling: preserve discriminator-referenced schemas as components instead of inlining them - Fix composed bundling: properly resolve discriminator mappings to full component paths - Add comprehensive tests to validate discriminator mapping preservation - Prevents invalid bundled specs with broken discriminator references
Fix Bundling with Discriminator Mapping Additional test with non existent discriminator Fix Windows File Handles Remove unrealistic conditions Re-Add Comment Add space Test last case Remove test logging Fix Fix last test Checkpoint Start from failure Fix Discriminator with Inline Bundling
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
=======================================
Coverage 99.63% 99.64%
=======================================
Files 169 169
Lines 22893 22962 +69
=======================================
+ Hits 22809 22880 +71
+ Misses 79 77 -2
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
daveshanley
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've closed my previous PR and decided to work on each issue piecemeal.
Inline Bundling Changes
oneOforanyOffor any ref, if it contains a discriminator mappingCons: Changes the behavior for the digital ocean spec, which is unfortunate since it's sort of the benchmark. But also I don't think it was working 100% correctly before