fix: normalize quoted user-invocable frontmatter#87
Open
Gujiassh wants to merge 2 commits intopbakaus:mainfrom
Open
fix: normalize quoted user-invocable frontmatter#87Gujiassh wants to merge 2 commits intopbakaus:mainfrom
Gujiassh wants to merge 2 commits intopbakaus:mainfrom
Conversation
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>
Only normalize quoted booleans for the user-invocable frontmatter flag so other quoted fields like argument-hint and description continue to round-trip as plain strings. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>
Contributor
Author
|
Follow-up fix pushed in 56ba63b. The failing CI turned out to be broader than the original quoted user-invocable case: quoted non-boolean values like |
Contributor
Author
|
Quick validation from my side on the current branch tip:
So the quoted-frontmatter normalization behavior covered by this PR is locally green on the current head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user-invocableflag (while keeping the legacyuser-invokablespelling readable too)description: 'true'into booleansreadSourceFilesTesting
bun test tests/lib/utils.test.jsPATH=/home/cc/tmp/bunshim:$PATH bun run build