Simplify URL decoding logic to reduce binary size#2
Open
Mquarmoc wants to merge 3 commits intopeachey2k2:masterfrom
Open
Simplify URL decoding logic to reduce binary size#2Mquarmoc wants to merge 3 commits intopeachey2k2:masterfrom
Mquarmoc wants to merge 3 commits intopeachey2k2:masterfrom
Conversation
- Eliminate unnecessary EAGAIN comparison - Remove redundant error message - Simplify error handling logic - Reduces binary size by ~15 bytes
- Replace complex bit operations with simpler arithmetic - Remove unnecessary register operations - Reduce code complexity while maintaining functionality - Reduces binary size by ~25 bytes
Replace complex bit operations with simpler arithmetic Remove unnecessary register operations Reduce code complexity while maintaining functionality Reduces binary size by ~25 bytes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace complex bit operations with simpler arithmetic
Remove unnecessary register operations
Reduce code complexity while maintaining functionality
Reduces binary size by ~25 bytes