Skip to content

fix: handle prices with more decimals than the token #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hugo0 merged 1 commit into from
Mar 3, 2025
Merged

fix: handle prices with more decimals than the token #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,9 +748,9 @@ export async function prepareXchainFromAmountCalculation({
// This ensures calculations are consistent and prevents issues with scientific notation
// that could arise from small price values or different token decimals.
const normalizedDecimalCount = Math.max(fromToken.decimals, toToken.decimals)
const fromTokenPriceBN = ethers.utils.parseUnits(fromTokenPrice.toString(), normalizedDecimalCount)
const toTokenPriceBN = ethers.utils.parseUnits(toTokenPrice.toString(), normalizedDecimalCount)
const toAmountBN = ethers.utils.parseUnits(toAmount, normalizedDecimalCount)
const fromTokenPriceBN = ethers.utils.parseUnits(fromTokenPrice.toFixed(normalizedDecimalCount), normalizedDecimalCount)
const toTokenPriceBN = ethers.utils.parseUnits(toTokenPrice.toFixed(normalizedDecimalCount), normalizedDecimalCount)
const toAmountBN = ethers.utils.parseUnits(Number(toAmount).toFixed(normalizedDecimalCount), normalizedDecimalCount)
const fromAmountBN = toTokenPriceBN.mul(toAmountBN).div(fromTokenPriceBN)
// Slippage percentage is multiplied by 1000 to convert it into an integer form that represents the fraction.
// because BigNumber cannot handle floating points directly.
Expand Down
Loading