fix: claim country currency and amount, fallback to $

[kushagrasarathe]

• contributes to TASK-14407 : qa change suggested by manu where currency should be local when claiming to bank account
• also fixes TASK-14147 : incorrect modal being shown when user just logged in using guest verification modal
• also fixes issue with bank account form where it would revert to initial view after saving user details and not initiating kyc flow
• also fixes issue where manually closing initiate kyc modal led to constant cta loading and blocking the flow

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
peanut-wallet	Ready	Preview	Comment	Sep 2, 2025 0:03am

[notion-workspace]

🪲 Bug: 0x address shown instead of Peanut user on activity tx

[coderabbitai]

Walkthrough

Allows guests to claim without waiting for user fetch, adds currency-aware amount rendering and loading state to bank-claim confirmation (with new PeanutActionDetailsCard isLoading/currencySymbol props and useCurrency isLoading), tightens token/network visibility for certain SEND_LINK history entries, guarantees isSubmitting reset in bank form, resets claim flow on login transition, and moves post-login redirect handling to a useEffect.

Changes

Cohort / File(s)	Summary
Claim gating src/components/Claim/Claim.tsx	Gating condition changed from !isFetchingUser to `!user
Confirm bank-claim & action details UI src/components/Claim/Link/views/Confirm.bank-claim.view.tsx, src/components/Global/PeanutActionDetailsCard/index.tsx, src/hooks/useCurrency.ts	ConfirmBankClaimView now derives target currency, fetches price/symbol via useCurrency, computes displayAmount/displaySymbol and passes amount, currencySymbol, and isLoading into PeanutActionDetailsCard. PeanutActionDetailsCard gains isLoading?: boolean and currencySymbol handling; currency symbol/unit rendering adjusted. useCurrency now manages and returns isLoading.
Token & network visibility src/components/TransactionDetails/TransactionDetailsReceipt.tsx	Token/network row visibility hardened: shown only if tokenDisplayDetails exists, sourceView === 'history', and the transaction is not a SEND_LINK originating from a SENDER.
Bank account form submission lifecycle src/components/AddWithdraw/DynamicBankAccountForm.tsx	Consolidates isSubmitting resets into a finally block so isSubmitting is always cleared on exit (removes per-branch resets); removed unused useEffect import.
Claim initial view login transition & modal visibility src/components/Claim/Link/Initial.view.tsx	Adds prevUser ref and useEffect to detect login transition and call resetClaimBankFlow; GuestVerificationModal now opens only for unauthenticated users (isOpen = showVerificationModal && !user).
Post-login redirect behavior src/components/Setup/Views/Welcome.tsx	Moves redirect handling to a useEffect that reads redirect from localStorage when user becomes available and navigates accordingly (clears key only when used); login button no longer performs the redirect.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Fix: Cancel button not showing for send and request link creator #1039 — Touches src/components/Claim/Claim.tsx and related claim/receipt loading flags; strong overlap on claim component changes.
• fix: send link claims to us bank accounts #1108 — Modifies Confirm.bank-claim.view.tsx; overlaps on bank-claim UI and currency/amount rendering.
• fix: external claim links history ui + badges fix #1136 — Adjusts TransactionDetailsReceipt visibility logic for SEND_LINK sender cases; directly related to the token/network row change.

Suggested reviewers

• Zishan-7
• jjramirezn

Suggested labels

enhancement

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/claim-currency

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (3)

src/components/TransactionDetails/TransactionDetailsReceipt.tsx (1)

197-223: Coingecko fetch: add ok-check, abort, and safer fallbacks

Direct client fetch to a public API without response.ok checks/abort may fail silently or race on re-renders. Also chainName may not match Coingecko platform ids. Prefer existing metadata sources if available; otherwise harden this fetch.

Example hardening:

 useEffect(() => {
   const getTokenDetails = async () => {
     if (!transaction) {
       setIsTokenDataLoading(false)
       return
     }

     if (transaction.tokenDisplayDetails?.tokenIconUrl && transaction.tokenDisplayDetails.tokenSymbol) {
       setTokenData({
         symbol: transaction.tokenDisplayDetails.tokenSymbol,
         icon: transaction.tokenDisplayDetails.tokenIconUrl,
       })
       setIsTokenDataLoading(false)
       return
     }

-    try {
-      const res = await fetch(
-        `https://api.coingecko.com/api/v3/coins/${transaction.tokenDisplayDetails?.chainName}/contract/${transaction.tokenAddress}`
-      )
-      const tokenDetails = await res.json()
-      setTokenData({
-        symbol: tokenDetails.symbol,
-        icon: tokenDetails.image.large,
-      })
-    } catch (e) {
+    const controller = new AbortController()
+    try {
+      const chainId = transaction.tokenDisplayDetails?.coingeckoPlatformId ?? transaction.tokenDisplayDetails?.chainName
+      const url = `https://api.coingecko.com/api/v3/coins/${chainId}/contract/${transaction.tokenAddress}`
+      const res = await fetch(url, { signal: controller.signal })
+      if (!res.ok) throw new Error(`Coingecko ${res.status}`)
+      const tokenDetails = await res.json()
+      setTokenData({
+        symbol: tokenDetails?.symbol?.toUpperCase?.() || transaction.tokenDisplayDetails?.tokenSymbol || '',
+        icon: tokenDetails?.image?.large || transaction.tokenDisplayDetails?.tokenIconUrl || '',
+      })
+    } catch (e) {
       console.error(e)
       setTokenData({
         symbol: '',
         icon: '',
       })
     } finally {
       setIsTokenDataLoading(false)
     }
   }

   getTokenDetails()
-}, [])
+  return () => controller.abort()
+}, [])

If we already have an internal token metadata provider, consider using that instead of Coingecko from the client.

src/components/Claim/Claim.tsx (1)

112-121: Compute originalUserRole based on current viewer
Refactor originalUserRole to use the authenticated user’s ID instead of hard-coding SENDER and include user in the memo dependencies:

src/components/Claim/Claim.tsx
             extraDataForDrawer: {
                 isLinkTransaction: true,
                 originalType: EHistoryEntryType.SEND_LINK,
-                originalUserRole: EHistoryUserRole.SENDER,
+                originalUserRole:
+                    user?.user.userId === claimLinkData.sender?.userId
+                        ? EHistoryUserRole.SENDER
+                        : EHistoryUserRole.RECIPIENT,
                 link: claimLinkData.link,
                 rewardData,
             },
...
-    }, [claimLinkData, interactions])
+    }, [claimLinkData, interactions, user])

src/hooks/useCurrency.ts (1)

11-16: Bug: hook doesn’t react to currencyCode prop changes

code is initialized from currencyCode but never updated when the input changes. Add a syncing effect.

Apply:

 export const useCurrency = (currencyCode: string | null) => {
   const [code, setCode] = useState<string | null>(currencyCode?.toUpperCase() ?? null)
   const [symbol, setSymbol] = useState<string | null>(null)
   const [price, setPrice] = useState<number | null>(null)
   const [isLoading, setIsLoading] = useState<boolean>(false)
+
+  useEffect(() => {
+    setCode(currencyCode?.toUpperCase() ?? null)
+  }, [currencyCode])

🧹 Nitpick comments (7)

src/components/TransactionDetails/TransactionDetailsReceipt.tsx (3)

103-103: Typo in comment

"acitvity" → "activity".

Apply:

-                // hide token and network for send links in acitvity drawer for sender
+                // hide token and network for send links in activity drawer for sender

---

262-434: Show currency symbol for Fee value

"Fee" currently renders a bare number (e.g., 1.23). For consistency with other amounts, prefix with $.

Apply:

-    const feeDisplay = transaction.fee !== undefined ? formatAmount(transaction.fee as number) : 'N/A'
+    const feeDisplay = transaction.fee !== undefined ? `$ ${formatAmount(transaction.fee as number)}` : 'N/A'

---

1007-1036: Null-asserted user in cancel modal

sendLinksApi.claim(user!.user.username!, ...) assumes user is always defined. While the button is gated for senders, a defensive check avoids runtime crashes if state desynchronizes.

Example:

-  sendLinksApi
-    .claim(user!.user.username!, transaction.extraDataForDrawer!.link!)
+  if (!user?.user?.username || !transaction.extraDataForDrawer?.link) {
+    setIsLoading(false)
+    return
+  }
+  sendLinksApi.claim(user.user.username, transaction.extraDataForDrawer.link)

src/hooks/useCurrency.ts (2)

4-9: Typo: rename SIMBOLS to SYMBOLS

Minor readability fix.

Apply:

-const SIMBOLS_BY_CURRENCY_CODE: Record<string, string> = {
+const SYMBOLS_BY_CURRENCY_CODE: Record<string, string> = {

And replace usages accordingly.

---

17-47: Avoid stale updates and add ok early-returns

Guard async updates against race conditions when code changes or component unmounts.

Apply:

-  useEffect(() => {
+  useEffect(() => {
+    let active = true
     if (!code) {
       setIsLoading(false)
       return
     }
@@
-    setIsLoading(true)
-    getCurrencyPrice(code)
-      .then((price) => {
-        setSymbol(SIMBOLS_BY_CURRENCY_CODE[code])
-        setPrice(price)
-        setIsLoading(false)
-      })
-      .catch((err) => {
-        console.error(err)
-        setIsLoading(false)
-      })
-  }, [code])
+    setIsLoading(true)
+    const currentCode = code
+    getCurrencyPrice(currentCode)
+      .then((p) => {
+        if (!active || currentCode !== code) return
+        setSymbol(SYMBOLS_BY_CURRENCY_CODE[currentCode])
+        setPrice(p)
+        setIsLoading(false)
+      })
+      .catch((err) => {
+        if (!active) return
+        console.error(err)
+        setIsLoading(false)
+      })
+    return () => {
+      active = false
+    }
+  }, [code])

src/components/Global/PeanutActionDetailsCard/index.tsx (1)

205-226: Withdraw display vs. historical learning: confirm spec

Current logic prefixes $ for USDC withdrawals and omits the trailing token label. Prior guidance for withdraw flows suggested explicitly showing “USDC” as the token symbol. Please confirm the desired UX and adjust either the prefix or trailing unit accordingly for withdraw views.

src/components/Claim/Link/views/Confirm.bank-claim.view.tsx (1)

70-86: Converted amount formatting

For non-USD, render with the shared formatter for locale-consistent decimals and grouping.

Apply:

-  const displayAmount = useMemo(() => {
+  const displayAmount = useMemo(() => {
     if (currencyCode === 'USD') return usdAmount
     if (isLoadingCurrency) return '-'
     if (!price || isNaN(price)) return usdAmount
-    const converted = (Number(usdAmount) * price).toFixed(2)
-    return converted
+    const converted = Number(usdAmount.replace(/,/g, '')) * price
+    return formatAmount(converted)
   }, [price, usdAmount, currencyCode, isLoadingCurrency])

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 24eb5b3 and 1307924.

📒 Files selected for processing (5)

• src/components/Claim/Claim.tsx (1 hunks)
• src/components/Claim/Link/views/Confirm.bank-claim.view.tsx (3 hunks)
• src/components/Global/PeanutActionDetailsCard/index.tsx (4 hunks)
• src/components/TransactionDetails/TransactionDetailsReceipt.tsx (1 hunks)
• src/hooks/useCurrency.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#919
File: src/components/Withdraw/views/Initial.withdraw.view.tsx:87-87
Timestamp: 2025-06-18T19:56:55.443Z
Learning: In withdraw flows for Peanut Wallet, the PeanutActionDetailsCard should always display "USDC" as the token symbol because it shows the amount being withdrawn from the Peanut Wallet (which holds USDC), regardless of the destination token/chain selected by the user. The TokenSelector is used for choosing the withdrawal destination, not the source display.

📚 Learning: 2024-11-18T21:36:11.486Z

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#535
File: src/components/Claim/Claim.tsx:142-146
Timestamp: 2024-11-18T21:36:11.486Z
Learning: In `src/components/Claim/Claim.tsx`, external calls like token price fetching and cross-chain details retrieval are already encapsulated within existing `try...catch` blocks, so additional error handling may be unnecessary.

Applied to files:

• src/components/Claim/Claim.tsx

📚 Learning: 2025-06-18T19:56:55.443Z

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#919
File: src/components/Withdraw/views/Initial.withdraw.view.tsx:87-87
Timestamp: 2025-06-18T19:56:55.443Z
Learning: In withdraw flows for Peanut Wallet, the PeanutActionDetailsCard should always display "USDC" as the token symbol because it shows the amount being withdrawn from the Peanut Wallet (which holds USDC), regardless of the destination token/chain selected by the user. The TokenSelector is used for choosing the withdrawal destination, not the source display.

Applied to files:

• src/components/Global/PeanutActionDetailsCard/index.tsx

🧬 Code graph analysis (3)

src/hooks/useCurrency.ts (1)

src/app/actions/currency.ts (1)

• getCurrencyPrice (7-50)

src/components/Global/PeanutActionDetailsCard/index.tsx (2)

src/app/[...recipient]/loading.tsx (1)

• Loading (3-5)

src/constants/zerodev.consts.ts (1)

• PEANUT_WALLET_TOKEN_SYMBOL (21-21)

src/components/Claim/Link/views/Confirm.bank-claim.view.tsx (2)

src/hooks/useCurrency.ts (1)

• useCurrency (11-55)

src/utils/bridge.utils.ts (1)

• getCurrencySymbol (45-52)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Deploy-Preview

🔇 Additional comments (6)

src/components/TransactionDetails/TransactionDetailsReceipt.tsx (1)

100-108: Sender-only hide: verify role semantics

Hiding the "Token and network" row only for SEND_LINK senders in history makes sense. However, this depends on extraDataForDrawer.originalUserRole reflecting the current viewer’s role, not the original actor. In Claim flow, we currently set this to SENDER unconditionally (see Claim.tsx lines 112-121), which could incorrectly hide the row for recipients. Please confirm and align the role source so the condition maps to the viewer context.

src/components/Claim/Claim.tsx (2)

216-224: Guest-fast path looks good

Allowing claim progression when no user is present meets the PR goal. The subsequent re-check after fetch will refine sender/recipient state. LGTM.

---

309-316: Drawer refresh cycle

onClose={() => checkLink(window.location.href)} re-fetches and may immediately reopen the drawer (depending on linkState). Confirm this won’t cause flicker or loops after cancel/claim actions.

src/components/Global/PeanutActionDetailsCard/index.tsx (1)

200-228: Header loading state: good UX improvement

Gating the amount render behind isLoading with a lightweight loader is clean and avoids layout shifts.

src/components/Claim/Link/views/Confirm.bank-claim.view.tsx (2)

71-72: Hook responsiveness to account changes

If bank details change (e.g., IBAN ↔ CLABE), currencyCode changes. Ensure useCurrency updates accordingly (requires the fix suggested in useCurrency.ts).

---

100-110: Card props wiring looks correct

Passing countryCodeForFlag, currencySymbol, and isLoading aligns with the new card API; amount will show once the rate resolves. LGTM.

[notion-workspace]

🪲 Bug: incorrect modal appears when claiming with bank account logged in and with User verified

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (5)

src/components/AddWithdraw/DynamicBankAccountForm.tsx (5)

98-101: Fix TDZ bug: don’t evaluate handleSubmit(onSubmit) before onSubmit is defined

This creates a ReferenceError during render. Defer the call so onSubmit is read at invocation time.

Apply:

-        useImperativeHandle(ref, () => ({
-            handleSubmit: handleSubmit(onSubmit),
-        }))
+        useImperativeHandle(ref, () => ({
+            handleSubmit: () => handleSubmit(onSubmit)(),
+        }))

---

71-72: Guard against undefined selectedCountry

toLowerCase() will throw if both countryNameFromProps and route param are absent.

-        let selectedCountry = (countryNameFromProps ?? (countryNameParams as string)).toLowerCase()
+        const selectedCountry = (countryNameFromProps ?? (countryNameParams as string) ?? country).toLowerCase()

---

229-239: Sanitize inputs consistently; comment currently mismatches behavior

Trim only removes edges; CLABE/IBAN/BIC/routing/account numbers often include inner spaces.

-                                onBlur={async (e) => {
-                                    // remove any whitespace from the input field
-                                    // note: @dev not a great fix, this should also be fixed in the backend
-                                    if (typeof field.value === 'string') {
-                                        field.onChange(field.value.trim())
-                                    }
+                                onBlur={async () => {
+                                    // normalize input: strip all whitespace for identifier fields; otherwise trim
+                                    if (typeof field.value === 'string') {
+                                        const needsStrictSanitization =
+                                            ['accountNumber', 'clabe', 'routingNumber', 'iban', 'bic'].includes(name as string)
+                                        const sanitized = needsStrictSanitization
+                                            ? field.value.replace(/\s+/g, '')
+                                            : field.value.trim()
+                                        field.onChange(sanitized)
+                                    }
                                     field.onBlur()
                                     if (onBlur) {
                                         await onBlur(field)
                                     }
                                 }}

---

141-149: IBAN → BIC: sanitize IBAN and normalize BIC to uppercase

Avoid lookup failures from spaces and store a canonical BIC.

-                            const autoBic = await getBicFromIban(accountNumber)
-                            if (autoBic) {
-                                bic = autoBic
-                                // set the BIC value in the form without showing the field
-                                setValue('bic', autoBic, { shouldValidate: false })
+                            const autoBic = await getBicFromIban(accountNumber.replace(/\s/g, ''))
+                            if (autoBic) {
+                                const normalizedBic = autoBic.trim().toUpperCase()
+                                bic = normalizedBic
+                                // set the BIC value in the form without showing the field
+                                setValue('bic', normalizedBic, { shouldValidate: false })

---

181-183: Strip whitespace from routing numbers before sending

Prevents backend rejects when users paste spaced numbers.

-                if (isUs && data.routingNumber) {
-                    payload.routingNumber = data.routingNumber
-                }
+                if (isUs && data.routingNumber) {
+                    payload.routingNumber = data.routingNumber.replace(/\s/g, '')
+                }

🧹 Nitpick comments (6)

src/components/Claim/Link/Initial.view.tsx (2)

113-121: Login-transition reset: good; tiny dependency nit

The prevUser-based guard cleanly scopes the reset to first login. If resetClaimBankFlow is a stable ref from context (likely), you can omit it from deps to avoid effect churn.

---

784-785: Align modal gating with user checks used elsewhere

Elsewhere in this file you gate on !!user?.user.userId. Here you check !user. To avoid inconsistent states during auth hydration, align the condition.

Apply:

-                isOpen={showVerificationModal && !user}
+                isOpen={showVerificationModal && !user?.user?.userId}

src/components/AddWithdraw/DynamicBankAccountForm.tsx (4)

128-131: Normalize user-entered BIC before use

Uppercase and trim to avoid validation issues.

                 const { firstName, lastName } = data
                 let bic = data.bic || getValues('bic')
                 const iban = data.iban || getValues('iban')
+                if (typeof bic === 'string') {
+                    bic = bic.trim().toUpperCase()
+                }

---

198-201: Handle unknown errors safely; avoid any in catch

Provides a user-friendly fallback message.

-            } catch (error: any) {
-                setSubmissionError(error.message)
+            } catch (err: unknown) {
+                const message =
+                    err instanceof Error ? err.message : 'Something went wrong while adding your bank. Please try again.'
+                setSubmissionError(message)

---

103-107: Remove console.log in production path

Keep noise out of prod logs; use debug and guard by env if needed.

-            if (isValidating) {
-                console.log('Validation still checking, skipping submission')
-                return
-            }
+            if (isValidating) {
+                if (process.env.NODE_ENV !== 'production') {
+                    console.debug('Validation still checking, skipping submission')
+                }
+                return
+            }

---

205-208: DRY compute isUs/isMx/isIban once

Minor cleanup: derive once with useMemo and reuse in onSubmit and render.

Example:

const isUs = useMemo(() => country.toUpperCase() === 'USA', [country])
const isMx = useMemo(() => country.toUpperCase() === 'MX', [country])
const isIban = useMemo(() => !(isUs || isMx) && isIBANCountry(country), [country, isUs, isMx])

Also applies to: 116-124

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1307924 and d2175d8.

📒 Files selected for processing (3)

• src/components/AddWithdraw/DynamicBankAccountForm.tsx (2 hunks)
• src/components/Claim/Link/Initial.view.tsx (2 hunks)
• src/components/Setup/Views/Welcome.tsx (2 hunks)

🧰 Additional context used

🧠 Learnings (5)

📓 Common learnings

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#535
File: src/components/Claim/Claim.tsx:142-146
Timestamp: 2024-11-18T21:36:11.486Z
Learning: In `src/components/Claim/Claim.tsx`, external calls like token price fetching and cross-chain details retrieval are already encapsulated within existing `try...catch` blocks, so additional error handling may be unnecessary.

📚 Learning: 2024-10-25T11:33:46.776Z

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#484
File: src/components/Cashout/Components/Initial.view.tsx:273-274
Timestamp: 2024-10-25T11:33:46.776Z
Learning: In the `InitialCashoutView` component (`src/components/Cashout/Components/Initial.view.tsx`), linked bank accounts should not generate error states, and the `ValidatedInput` component will clear any error messages if needed. Therefore, it's unnecessary to manually clear the error state when selecting or clearing linked bank accounts.

Applied to files:

• src/components/Claim/Link/Initial.view.tsx
• src/components/AddWithdraw/DynamicBankAccountForm.tsx

📚 Learning: 2025-01-16T13:14:40.363Z

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#631
File: src/components/Create/Create.tsx:108-112
Timestamp: 2025-01-16T13:14:40.363Z
Learning: In the Peanut UI codebase, the `resetTokenContextProvider` function from `tokenSelectorContext` is a stable function reference that doesn't change, so it doesn't need to be included in useEffect dependencies.

Applied to files:

• src/components/Claim/Link/Initial.view.tsx

📚 Learning: 2024-12-02T17:19:18.532Z

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#551
File: src/components/Request/Create/Views/Initial.view.tsx:151-156
Timestamp: 2024-12-02T17:19:18.532Z
Learning: In the `InitialView` component at `src/components/Request/Create/Views/Initial.view.tsx`, when setting the default chain and token in the `useEffect` triggered by `isPeanutWallet`, it's acceptable to omit the setters from the dependency array and not include additional error handling for invalid defaults.

Applied to files:

• src/components/Claim/Link/Initial.view.tsx

📚 Learning: 2025-08-22T07:28:32.281Z

Learnt from: Zishan-7
PR: peanutprotocol/peanut-ui#1104
File: src/components/Payment/PaymentForm/index.tsx:522-545
Timestamp: 2025-08-22T07:28:32.281Z
Learning: In `src/components/Payment/PaymentForm/index.tsx`, the `handleCompleteDaimoPayment` function is only for updating payment status in the backend after a successful Daimo payment. Payment success/failure is handled by Daimo itself, so try/catch error handling and error display are not needed for backend sync failures - users shouldn't see errors if payment succeeded but database update failed.

Applied to files:

• src/components/AddWithdraw/DynamicBankAccountForm.tsx

🧬 Code graph analysis (1)

src/components/Setup/Views/Welcome.tsx (1)

src/utils/general.utils.ts (1)

• getFromLocalStorage (126-148)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Deploy-Preview

🔇 Additional comments (2)

src/components/Setup/Views/Welcome.tsx (1)

56-58: LGTM: redirect moved out of onClick

Button now strictly handles login; navigation is centralized in the effect. Cleaner separation of concerns.

src/components/AddWithdraw/DynamicBankAccountForm.tsx (1)

164-176: Confirm backend expects 'USA' vs 'US' and lowercase countryName

Both countryCode and countryName formats vary by API; mismatches can 4xx.

Please confirm the Users service schema:

• countryCode: expected values for United States and Mexico? ('USA'/'US', 'MEX'/'MX')
• countryName: expects full name/title case vs lowercase slug (you send selectedCountry, lowercased).
  If needed, I can patch to map to the required schema.