Skip to content

Remove tooltip and add modal in Identity verification flow in settings#1263

Merged
Zishan-7 merged 3 commits intopeanut-wallet-devfrom
feat/identity-verification-modal
Oct 6, 2025
Merged

Remove tooltip and add modal in Identity verification flow in settings#1263
Zishan-7 merged 3 commits intopeanut-wallet-devfrom
feat/identity-verification-modal

Conversation

@Zishan-7
Copy link
Copy Markdown
Contributor

image

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
peanut-wallet Ready Ready Preview Comment Oct 6, 2025 8:09am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Sep 30, 2025

Walkthrough

Replaces direct navigation from the Profile "Identity Verification" item with modal-driven flows: adds local UI state to open either an "already verified" modal or an "initiate KYC" modal; new modals provide CTAs to navigate to /profile/identity-verification or dismiss; removes tooltip props.

Changes

Cohort / File(s) Summary
Profile KYC modal changes
src/components/Profile/index.tsx
Adds local state (isKycApprovedModalOpen, showInitiateKycModal) and imports ActionModal; renders two modals (KYC already verified and initiate KYC); replaces direct navigation on Identity Verification click with conditional modal opening; removes showTooltip and toolTipText props from the Identity Verification menu item; adds modal CTAs ("Go back", "Verify now", "Not now") and navigation from "Verify now" to /profile/identity-verification.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • kushagrasarathe
  • jjramirezn

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title clearly summarizes the core change by indicating both the removal of a tooltip and the addition of a modal in the identity verification settings flow, matching the changes introduced in the code.
Description Check ✅ Passed The pull request description includes a screenshot of the updated UI flow reflecting the new identity verification modals, so it is clearly related to the changes made in the code.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/identity-verification-modal

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a556646 and 2f03a3a.

📒 Files selected for processing (1)
  • src/components/Profile/index.tsx (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/components/Profile/index.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Deploy-Preview

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot added the enhancement New feature or request label Sep 30, 2025
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/components/Profile/index.tsx (1)

142-165: Simplify redundant responsive class.

The ctaClassName applies flex-col at both the base and sm: breakpoints. Since they're identical, you can simplify to just flex-col.

Apply this diff:

                 icon="shield"
-                ctaClassName="flex-col sm:flex-col"
+                ctaClassName="flex-col"
                 ctas={[

Otherwise, the modal implementation is well-structured with clear CTAs and appropriate messaging.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 72b3606 and dc41841.

📒 Files selected for processing (1)
  • src/components/Profile/index.tsx (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Deploy-Preview
🔇 Additional comments (2)
src/components/Profile/index.tsx (2)

19-19: LGTM!

The state declaration follows React conventions and is properly initialized.


65-71: Remove navigation-prevention suggestion. The ProfileMenuItem component renders a plain Card (no <Link>) whenever an onClick prop is provided, so there’s no default navigation to cancel.

Likely an incorrect or invalid review comment.

@notion-workspace
Copy link
Copy Markdown

@Zishan-7 Zishan-7 merged commit b60fa31 into peanut-wallet-dev Oct 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants