Wait before we actually need to process the image for checking if Pillow can handle it. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfournier
force-pushed
the
pillow-lazy-check
branch
3 times, most recently
from
41a5152 to
90c3fc1
Compare
minchinweb
requested changes
Feb 7, 2023
There was a problem hiding this comment.
@patrickfournier thank you, as always, for this. I think it would work (functionally) as is, but I've added some note that I think would improve it.
minchinweb
added a commit
that referenced
this pull request
Mar 7, 2024
…recommendations Add Release.md Closes #72 # Conflicts: # pelican/plugins/image_process/image_process.py
|
@patrickfournier: What do you think about the suggestions @minchinweb made here? It would be great to get your improvements merged 😊 |
…low can handle it. This avoids loading the image needlessly.
- Put filename in quotes. - Re-raise exception instead of return None. - Use f-string instead of format.
patrickfournier
force-pushed
the
pillow-lazy-check
branch
from
4fb41a8 to
41c759c
Compare
|
@justinmayer Thanks for reminding me about this. I just pushed changes to add @minchinweb suggestions. |
|
@patrickfournier: Many thanks for the follow-up changes based on @minchinweb's suggestions. Would be so kind as to resolve the merge conflict here so we can merge this pull request? |
# Conflicts: # pelican/plugins/image_process/test_image_process.py
|
Done! |
|
Thank you both for making this happen! |
minchinweb
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids loading the image needlessly.