Simplified XML header and removed obsolet schema references#46
Closed
max-pfeiffer wants to merge 1 commit into
Closed
Simplified XML header and removed obsolet schema references#46max-pfeiffer wants to merge 1 commit into
max-pfeiffer wants to merge 1 commit into
Conversation
max-pfeiffer
force-pushed
the
bugfix/xml-header
branch
from
November 22, 2025 11:17
728e62e to
4b4fbd4
Compare
kernc
reviewed
Nov 25, 2025
| XML_HEADER = """<?xml version="1.0" encoding="utf-8"?> | ||
| <urlset xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://www.sitemaps.org/schemas/sitemap/0.9 http://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd" | ||
| xmlns:xhtml="http://www.w3.org/1999/xhtml" |
Member
There was a problem hiding this comment.
Html namespace is still used further below:
It is referenced here: https://developers.google.com/search/docs/specialty/international/localized-versions#sitemap
Author
There was a problem hiding this comment.
Good point. I was not aware of this detail. So what about a header like this then:
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9" xmlns:xhtml="http://www.w3.org/1999/xhtml">
Member
There was a problem hiding this comment.
Lgtm. 🤷
The others are from https://sitemaps.org/protocol.html#validating — They're obsolete?
Author
There was a problem hiding this comment.
Hmm, maybe not. Let's just close this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #44