Skip to content

Conversation

N3xp7im3
Copy link

It might be possible that the storage device does not probe fast enough causing an error when trying to mount it. Thus, we should wait for it passively before proceeding with the code. Depending on which features are enabled we have to wait at different code paths.

@michaelolbrich
Copy link
Member

The clippy error is also present in main. It changed with the latest rust version. That will need a separate fix.

@michaelolbrich
Copy link
Member

Please rebase. That should fix the failed tests.

@N3xp7im3 N3xp7im3 force-pushed the wait-for-device branch 3 times, most recently from 994221e to 50f25cd Compare April 17, 2025 15:33
@N3xp7im3 N3xp7im3 requested a review from michaelolbrich April 25, 2025 09:08
@N3xp7im3
Copy link
Author

Should I squash your changes into my commit or should I leave it as separate commit? @hnez

@hnez
Copy link
Member

hnez commented May 26, 2025

Should I squash your changes into my commit or should I leave it as separate commit? @hnez

Please squash them. I don't care too much about attribution here and squashing makes the history easier to follow.

It might be possible that the storage device does not probe fast enough
causing an error when trying to mount it. Thus, we should wait for it
passively before proceeding with the code.

Signed-off-by: Fabian Pfitzner <[email protected]>
Co-authored-by: Leonard Göhrs <[email protected]>
Signed-off-by: Fabian Pfitzner <[email protected]>
@michaelolbrich michaelolbrich merged commit ae41570 into pengutronix:main Aug 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants