waiting for device to exist #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The clippy error is also present in main. It changed with the latest rust version. That will need a separate fix. |
|
Please rebase. That should fix the failed tests. |
michaelolbrich
requested changes
Apr 16, 2025
N3xp7im3
force-pushed
the
wait-for-device
branch
3 times, most recently
from
994221e to
50f25cd
Compare
N3xp7im3
force-pushed
the
wait-for-device
branch
from
50f25cd to
9a35afa
Compare
N3xp7im3
force-pushed
the
wait-for-device
branch
from
9a35afa to
4e6cbfa
Compare
hnez
reviewed
May 8, 2025
hnez
reviewed
May 8, 2025
hnez
reviewed
May 8, 2025
|
Should I squash your changes into my commit or should I leave it as separate commit? @hnez |
Please squash them. I don't care too much about attribution here and squashing makes the history easier to follow. |
N3xp7im3
force-pushed
the
wait-for-device
branch
from
9bf92f5 to
0dbcf00
Compare
pH5
reviewed
Jun 17, 2025
N3xp7im3
force-pushed
the
wait-for-device
branch
from
0dbcf00 to
8eaa635
Compare
michaelolbrich
approved these changes
Aug 1, 2025
It might be possible that the storage device does not probe fast enough causing an error when trying to mount it. Thus, we should wait for it passively before proceeding with the code. Signed-off-by: Fabian Pfitzner <[email protected]> Co-authored-by: Leonard Göhrs <[email protected]> Signed-off-by: Fabian Pfitzner <[email protected]>
N3xp7im3
force-pushed
the
wait-for-device
branch
from
8eaa635 to
740fc3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be possible that the storage device does not probe fast enough causing an error when trying to mount it. Thus, we should wait for it passively before proceeding with the code. Depending on which features are enabled we have to wait at different code paths.