PMM-14321: fix pmm-agent crashing when querying system variables #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bounds checking bug in the query fingerprinting logic that could cause an index out of bounds error when processing certain SQL queries. The fix adds a length check before accessing q[qi+1] to prevent potential panics.
- Added bounds checking to prevent index out of range errors
- Added test coverage for system variable queries that trigger the edge case
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| query/query.go | Added bounds check (qi+1 < len(q)) before accessing q[qi+1] to prevent index out of bounds errors |
| query/query_test.go | Added test case for system variable queries to verify the bug fix works correctly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BupycHuk
approved these changes
Oct 30, 2025
This was referenced Oct 31, 2025
JiriCtvrtka
approved these changes
Nov 6, 2025
|
|
idoqo
force-pushed
the
PMM-14321-slowlog-crashes
branch
from
153252e to
c2df7b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-14321