Fix: Exporter not initiating connection to mongo when Unauthorized #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudigit
requested review from
BupycHuk and
JiriCtvrtka
and removed request for
a team
|
|
dudigit
force-pushed
the
release-0.41.3-treat-collection-when-unauthorized
branch
from
04823da to
4943042
Compare
|
Hi @dudigit please sign the GitHub CLA mentioned above |
idoqo
reviewed
Jan 24, 2025
Dockerfile
Outdated
There was a problem hiding this comment.
This completely changes how we build the docker image, is there any reason why?
There was a problem hiding this comment.
This change was pushed by mistake, it will be fixed
dudigit
commented
Jan 26, 2025
dudigit
force-pushed
the
release-0.41.3-treat-collection-when-unauthorized
branch
from
ec90495 to
9830cc1
Compare
|
@idoqo The SLA was signed :-) |
dudigit
force-pushed
the
release-0.41.3-treat-collection-when-unauthorized
branch
from
9830cc1 to
636ed82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-XXXX (optional, if ticket reported)
Below we provide a basic checklist of things that would make it a good PR:
Once all checks pass and the code is ready for review, please add
pmm-review-exportersteam as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.