Skip to content

[fix] delete endpoint /debug #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

Format-C-eft
Copy link
Contributor

This MR proposes the removal of the default /debug endpoint, which is automatically registered by the net/http standard library. The /debug endpoint exposes debugging information that may include sensitive data, posing a potential security risk in production environments.

Key changes:

  1. Removed the registration of the /debug handler via http.DefaultServeMux.

Benefits:

  1. Eliminates a potential security vulnerability related to the exposure of debugging information.
  2. Reduces the risk of data leakage in production environments.
  3. Please review the changes and provide feedback.

@Format-C-eft Format-C-eft requested a review from a team as a code owner June 23, 2025 13:57
@Format-C-eft Format-C-eft requested review from BupycHuk and JiriCtvrtka and removed request for a team June 23, 2025 13:57
@it-percona-cla
Copy link

it-percona-cla commented Jun 23, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.50%. Comparing base (dc46ed5) to head (ff3ab8d).
Report is 107 commits behind head on main.

Files with missing lines Patch % Lines
exporter/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1099      +/-   ##
==========================================
- Coverage   70.88%   65.50%   -5.39%     
==========================================
  Files          28       29       +1     
  Lines        3569     3073     -496     
==========================================
- Hits         2530     2013     -517     
- Misses        904      922      +18     
- Partials      135      138       +3     
Flag Coverage Δ
agent 65.50% <0.00%> (-5.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BupycHuk BupycHuk merged commit c30b2ba into percona:main Jun 24, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants