PMM-13794 fix pmm agent on pmm server #4032
Open
+417
−369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce goroutines and mutexes to improve concurrency handling in HA services. Added safeguards to ensure thread-safe operations and improved logging for better traceability. This ensures smoother service start/stop processes and handles errors more gracefully.
Introduce goroutines and mutexes to improve concurrency handling in HA services. Added safeguards to ensure thread-safe operations and improved logging for better traceability. This ensures smoother service start/stop processes and handles errors more gracefully.
BupycHuk
requested review from
idoqo and
JiriCtvrtka
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #4032 +/- ##
==========================================
- Coverage 43.68% 42.97% -0.71%
==========================================
Files 369 369
Lines 45165 45232 +67
==========================================
- Hits 19731 19440 -291
- Misses 23729 24116 +387
+ Partials 1705 1676 -29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ademidoff
reviewed
May 19, 2025
| @@ -56,7 +56,7 @@ | |||
| host: 127.0.0.1 | |||
| port: 5432 | |||
| timeout: 150 | |||
| when: lookup('env','PMM_POSTGRES_ADDR') == '127.0.0.1:5432' and lookup('env','PMM_DISABLE_BUILTIN_POSTGRES') != '1' | |||
| when: lookup('env','GF_DATABASE_URL') == '' and lookup('env','GF_DATABASE_HOST') == '' and lookup('env','PMM_DISABLE_BUILTIN_POSTGRES') == '' | |||
There was a problem hiding this comment.
What if the user sets PMM_DISABLE_BUILTIN_POSTGRES to 0?
There was a problem hiding this comment.
it will be very weird decission 😊, but this solution is easier to support then multiple variations of True value
There was a problem hiding this comment.
Well, there is a better way, as usual. For example, we could solve it with the following syntax:
when:
- lookup('env','GF_DATABASE_URL') == ''
- lookup('env','GF_DATABASE_HOST') == ''
- not (lookup('env','PMM_DISABLE_BUILTIN_POSTGRES') | bool)
Co-authored-by: Alex Demidoff <[email protected]>
JiriCtvrtka
approved these changes
May 19, 2025
Moved high-availability (HA) configuration to a new docker-compose.ha.yml file, isolating it from the default compose file. This improves maintainability and provides a cleaner separation between standard and HA setups.
ademidoff
approved these changes
May 19, 2025
Added environment variables, healthchecks, and better dependency conditions for services to enhance reliability. Adjusted network ports, volumes, and configurations for PostgreSQL and ClickHouse. Deprecated unused parameters and ensured compatibility with multi-platform builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13794
Link to the Feature Build: SUBMODULES-3927
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: