Skip to content

PMM-7 Skip PMM agent setup if already configured #4051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from

Conversation

BupycHuk
Copy link
Member

@BupycHuk BupycHuk commented May 27, 2025

Added a check to determine if the PMM agent is already configured by verifying the presence of an existing configuration. If the agent is configured, the setup process is skipped, preventing unnecessary reconfiguration. This optimizes startup behavior and avoids redundant setup operations.

PMM-7

Link to the Feature Build: SUBMODULES-3941

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

Added a check to determine if the PMM agent is already configured by verifying the presence of an existing configuration. If the agent is configured, the setup process is skipped, preventing unnecessary reconfiguration. This optimizes startup behavior and avoids redundant setup operations.
@BupycHuk BupycHuk requested a review from a team as a code owner May 27, 2025 14:39
@BupycHuk BupycHuk requested review from idoqo and JiriCtvrtka and removed request for a team May 27, 2025 14:39
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 43.58%. Comparing base (f48899c) to head (5bc2651).

Files with missing lines Patch % Lines
agent/cmd/pmm-agent-entrypoint/main.go 0.00% 40 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #4051      +/-   ##
==========================================
- Coverage   43.60%   43.58%   -0.03%     
==========================================
  Files         369      369              
  Lines       45225    45246      +21     
==========================================
  Hits        19719    19719              
- Misses      23798    23819      +21     
  Partials     1708     1708              
Flag Coverage Δ
agent 52.51% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant