Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPA executable path #680

Merged
merged 8 commits into from
Nov 17, 2024
Merged

OPA executable path #680

merged 8 commits into from
Nov 17, 2024

Conversation

daveads
Copy link
Contributor

@daveads daveads commented Oct 11, 2024 •
edited
Loading

/claim #676

feat(opal-client): Add configurable OPA executable path

  • Introduce INLINE_OPA_EXECUTABLE_PATH configuration option
  • Update OpaRunner to use configurable path for OPA executable
  • Default to 'opa' if no custom path is specified
  • Update setup_opa_runner to handle the new configuration

@netlify Netlify
Copy link

netlify bot commented Oct 11, 2024 •
edited
Loading

✅ Deploy Preview for opal-docs canceled.

Name Link
🔨 Latest commit 06d74ab
🔍 Latest deploy log https://app.netlify.com/sites/opal-docs/deploys/673a22df2a0691000892b7b5

@algora-pbc algora-pbc bot mentioned this pull request Oct 11, 2024
Open
@daveads
Copy link
Contributor Author

daveads commented Oct 11, 2024

@danyi1212 review when free....

@gemanor gemanor requested a review from danyi1212 October 13, 2024 20:53
@gemanor
Copy link
Collaborator

gemanor commented Oct 13, 2024

Hey @daveads can you please check why the test isn't pass before asking @danyi1212 for a review?

@daveads
Copy link
Contributor Author

daveads commented Oct 13, 2024

Hey @daveads can you please check why the test isn't pass before asking @danyi1212 for a review?

sure

@daveads
Copy link
Contributor Author

daveads commented Oct 14, 2024 

 Cloning into 'opal-tests-policy-repo'...
Load key "/home/runner/work/opal/opal/app-tests/opal-tests-policy-repo-key": error in libcrypto
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

This suggests that the SSH key is not being recognized or doesn't have the correct permissions.

@daveads
Copy link
Contributor Author

daveads commented Oct 14, 2024

pre-commit / pre-commit (pull_request) FIX

#683

@daveads
Copy link
Contributor Author

daveads commented Nov 17, 2024

@danyi1212 @gemanor

Good to go ?

@danyi1212 danyi1212 merged commit 3409036 into permitio:master Nov 17, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyi1212 danyi1212 danyi1212 approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daveads @gemanor @danyi1212