Skip to content

[FEATURE] mark old CRD versions as deprecated #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgbernalp merged 1 commit into from
Jan 13, 2026
Merged

[FEATURE] mark old CRD versions as deprecated #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ docker-buildx: test ## Build and push docker image for the manager for cross-pla

.PHONY: podman-cross-build
podman-cross-build: test
podman manifest create ${IMG}
podman manifest create -a ${IMG}
podman build --platform $(PLATFORMS) --manifest ${IMG} -f Dockerfile.dev
podman manifest push ${IMG}

Expand Down
1 change: 1 addition & 0 deletions api/v1alpha1/perses_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ type PersesStatus struct {
//+kubebuilder:object:root=true
//+kubebuilder:subresource:status
//+kubebuilder:resource:shortName=per
//+kubebuilder:deprecatedversion:warning="perses.dev/v1alpha1 is deprecated; use perses.dev/v1alpha2"

// Perses is the Schema for the perses API
type Perses struct {
Expand Down
1 change: 1 addition & 0 deletions api/v1alpha1/persesdashboard_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ type PersesDashboardStatus struct {
//+kubebuilder:object:root=true
//+kubebuilder:subresource:status
//+kubebuilder:resource:shortName=perdb
//+kubebuilder:deprecatedversion:warning="perses.dev/v1alpha1 is deprecated; use perses.dev/v1alpha2"

// PersesDashboard is the Schema for the persesdashboards API
type PersesDashboard struct {
Expand Down
7 changes: 4 additions & 3 deletions api/v1alpha1/persesdatasource_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@ type DatasourceSpec struct {
Client *Client `json:"client,omitempty"`
}

// +kubebuilder:object:root=true
// +kubebuilder:subresource:status
// +kubebuilder:resource:shortName=perds
//+kubebuilder:object:root=true
//+kubebuilder:subresource:status
//+kubebuilder:resource:shortName=perds
//+kubebuilder:deprecatedversion:warning="perses.dev/v1alpha1 is deprecated; use perses.dev/v1alpha2"

// PersesDatasource is the Schema for the PersesDatasources API
type PersesDatasource struct {
Expand Down
4 changes: 3 additions & 1 deletion config/crd/bases/perses.dev_perses.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ spec:
singular: perses
scope: Namespaced
versions:
- name: v1alpha1
- deprecated: true
deprecationWarning: perses.dev/v1alpha1 is deprecated; use perses.dev/v1alpha2
name: v1alpha1
schema:
openAPIV3Schema:
description: Perses is the Schema for the perses API
Expand Down
4 changes: 3 additions & 1 deletion config/crd/bases/perses.dev_persesdashboards.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ spec:
singular: persesdashboard
scope: Namespaced
versions:
- name: v1alpha1
- deprecated: true
deprecationWarning: perses.dev/v1alpha1 is deprecated; use perses.dev/v1alpha2
name: v1alpha1
schema:
openAPIV3Schema:
description: PersesDashboard is the Schema for the persesdashboards API
Expand Down
4 changes: 3 additions & 1 deletion config/crd/bases/perses.dev_persesdatasources.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ spec:
singular: persesdatasource
scope: Namespaced
versions:
- name: v1alpha1
- deprecated: true
deprecationWarning: perses.dev/v1alpha1 is deprecated; use perses.dev/v1alpha2
name: v1alpha1
schema:
openAPIV3Schema:
description: PersesDatasource is the Schema for the PersesDatasources API
Expand Down
4 changes: 3 additions & 1 deletion jsonnet/examples/0persesCustomResourceDefinition.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ spec:
singular: perses
scope: Namespaced
versions:
- name: v1alpha1
- deprecated: true
deprecationWarning: perses.dev/v1alpha1 is deprecated; use perses.dev/v1alpha2
name: v1alpha1
schema:
openAPIV3Schema:
description: Perses is the Schema for the perses API
Expand Down
4 changes: 3 additions & 1 deletion jsonnet/examples/0persesdashboardsCustomResourceDefinition.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ spec:
singular: persesdashboard
scope: Namespaced
versions:
- name: v1alpha1
- deprecated: true
deprecationWarning: perses.dev/v1alpha1 is deprecated; use perses.dev/v1alpha2
name: v1alpha1
schema:
openAPIV3Schema:
description: PersesDashboard is the Schema for the persesdashboards API
Expand Down
4 changes: 3 additions & 1 deletion jsonnet/examples/0persesdatasourcesCustomResourceDefinition.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ spec:
singular: persesdatasource
scope: Namespaced
versions:
- name: v1alpha1
- deprecated: true
deprecationWarning: perses.dev/v1alpha1 is deprecated; use perses.dev/v1alpha2
name: v1alpha1
schema:
openAPIV3Schema:
description: PersesDatasource is the Schema for the PersesDatasources API
Expand Down
2 changes: 2 additions & 0 deletions jsonnet/generated/perses.dev_perses-crd.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
"scope": "Namespaced",
"versions": [
{
"deprecated": true,
"deprecationWarning": "perses.dev/v1alpha1 is deprecated; use perses.dev/v1alpha2",
"name": "v1alpha1",
"schema": {
"openAPIV3Schema": {
Expand Down
2 changes: 2 additions & 0 deletions jsonnet/generated/perses.dev_persesdashboards-crd.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
"scope": "Namespaced",
"versions": [
{
"deprecated": true,
"deprecationWarning": "perses.dev/v1alpha1 is deprecated; use perses.dev/v1alpha2",
"name": "v1alpha1",
"schema": {
"openAPIV3Schema": {
Expand Down
2 changes: 2 additions & 0 deletions jsonnet/generated/perses.dev_persesdatasources-crd.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
"scope": "Namespaced",
"versions": [
{
"deprecated": true,
"deprecationWarning": "perses.dev/v1alpha1 is deprecated; use perses.dev/v1alpha2",
"name": "v1alpha1",
"schema": {
"openAPIV3Schema": {
Expand Down