-
Notifications
You must be signed in to change notification settings - Fork 0
Visualize robot motion #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this! The requested changes are quite small; once you have made them this should be ready to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See requested changes below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe this pull request. Link to relevant GitHub issues, if any.
This PR includes issue #22 deliverables as detailed in the following:
TODO: the responsiveness problems of header (such as fitting all buttons/icons) will be addressed in the app responsiveness issue #9
Explain how this pull request was tested, including but not limited to the below checkmarks.
I tested the implementations by running the app screens in my local Ubuntu 22 chromium browser and ensuring:
Before creating a pull request
npm run format
python3 -m black .
in the top-level of this repositoryBefore merging a pull request
Squash and Merge
)