Skip to content

Visualize robot motion #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 26, 2023
Merged

Visualize robot motion #54

merged 13 commits into from
May 26, 2023

Conversation

Raidakarim
Copy link
Contributor

@Raidakarim Raidakarim commented May 18, 2023

Describe this pull request. Link to relevant GitHub issues, if any.

This PR includes issue #22 deliverables as detailed in the following:

  • Lock icon (svg image in react button) design and implementation for stopped/paused motion in the header implemented
  • CircleProgressBar functional component implementation that contains circle progress bar with green color showing smooth progression, gray trail line, progress level percentage in text, circle formation in progress rate of robot motion
  • Some readme comments for Ubuntu 22 and corresponding installation that will help with dummy nodes running in local
  • Add motion time in moving screen above the progress bar
  • Add text when user refreshes page in paused mode

TODO: the responsiveness problems of header (such as fitting all buttons/icons) will be addressed in the app responsiveness issue #9

Explain how this pull request was tested, including but not limited to the below checkmarks.

I tested the implementations by running the app screens in my local Ubuntu 22 chromium browser and ensuring:

  • the lock icon appear in the header in robot's non-moving states and when the pause button is clicked
  • the circle progress bar appears in robot's moving screens and when the robot is not paused
  • the circle progress bar shows the correct progress level in its text and smoothly forms the circle at this rate, when run along with dummy nodes
  • motion time appears in moving screens as expected
  • refreshing page in different devices rendered text in paused mode

Before creating a pull request

  • Format React code with npm run format
  • [N/A] Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • [N/A] Thoroughly test your code's responsiveness by rendering it on different devices, browsers, etc.
  • Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@Raidakarim Raidakarim requested a review from amalnanavati May 23, 2023 16:52
@Raidakarim Raidakarim self-assigned this May 24, 2023
@amalnanavati amalnanavati linked an issue May 24, 2023 that may be closed by this pull request
Copy link
Contributor

@amalnanavati amalnanavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! The requested changes are quite small; once you have made them this should be ready to approve.

@Raidakarim Raidakarim requested a review from amalnanavati May 24, 2023 22:27
Copy link
Contributor

@amalnanavati amalnanavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See requested changes below.

@Raidakarim Raidakarim requested a review from amalnanavati May 26, 2023 06:01
Copy link
Contributor

@amalnanavati amalnanavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Raidakarim Raidakarim merged commit 2c5574f into main May 26, 2023
@Raidakarim Raidakarim deleted the raidak/robot_motion branch May 26, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide visual indications of near-future robot motions
2 participants