Bugfix/odom twist worldframe #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ClintLiddick
commented
Aug 12, 2015
ClintLiddick
commented
- Merge updates from upstream master
- publish odom's twist component as velocities relative to base_link, rather than world
…ame_ids allow parametrizing odometry frame id as well (useful for multiple robots)
|
I think you should actually send this pull request upstream. Is there any reason you made this pull request against our fork, instead? |
|
Give you guys a chance to take a look, and can make the upstream request from the lab. I can make the pull request myself if that makes more sense. |
|
Sounds good to me. |
mkoval
added a commit
that referenced
this pull request
Aug 12, 2015
Publish the Odometry message twist in the body frame (as per the spec).
|
I sent this upstream here: segwayrmp#28. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.