Limit multiple actions

[huksley]

@peterkhayes Hi, here is the pretty naive implementation, would this work?

I think not, because ...Info() methods return always actionsRemaining == maxInInterval - 1, however, it is my expectation what there would be maxInterval available.

Could you take a look at this? I find all multithreaded programming extremely difficult to implement right.

Feeble attempt to fix #58

[peterkhayes]

Could you also update the readme, under the Instance Methods section, to add the new parameter?

[huksley]

It seems that actionsRemaining is broken for all operations - it always returns N-1, because of

I added also test at src/index.test.ts:107 which will not succeed even without my changes

    it('prevents more than maxInInterval actions within interval', async () => {
      const options = { interval: 10, maxInInterval: 2 };
      const limiter = await createLimiter(options);

      // Should allow first action through.
      setTime(0);
      // Should have 2 actions available at start
      expect(await limiter.wouldLimitWithInfo(id)).toEqual({
        actionsRemaining: 2,
        blocked: false,
        blockedDueToCount: false,
        blockedDueToMinDifference: false,
        millisecondsUntilAllowed: 0,
      });

At least that's how I expect library to behave, am I wrong?

[peterkhayes]

nice catch!