Add classic editor fallback for webmention post settings #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfefferle
reviewed
Jul 6, 2025
| @@ -36,6 +37,41 @@ public static function init() { | |||
|
|
|||
| // remote delete posts | |||
| add_action( 'webmention_delete', array( static::class, 'send_webmentions' ) ); | |||
| \add_action( 'init', array( self::class, 'register_postmeta' ), 11 ); | |||
There was a problem hiding this comment.
Suggested change
| \add_action( 'init', array( self::class, 'register_postmeta' ), 11 ); | |
| self::register_postmeta(); |
I think the init function is already triggered on init?
There was a problem hiding this comment.
This makes sense. I moved the code there and wasn't thinking.
pfefferle
reviewed
Jul 6, 2025
| /** | ||
| * Register post meta | ||
| */ | ||
| public static function register_postmeta() { |
There was a problem hiding this comment.
Suggested change
| public static function register_postmeta() { | |
| public static function register_meta() { |
The other function is called register_meta I think we should be consistent. I have no preference which one to use.
There was a problem hiding this comment.
Same, moved it around...fine with changing it.
|
Thanks @dshanske ! I have some inline feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #527
Moved the meta settings to receiver and sender functions, consistent with early design, as they aren't block specific any longer. It sets up a metabox that will appear only in the Classic Editor and Classic Press.