Skip to content

add nui windows#11

Draft
pfeiferj wants to merge 1 commit intomainfrom
ui-options
Draft

add nui windows#11
pfeiferj wants to merge 1 commit intomainfrom
ui-options

Conversation

@pfeiferj
Copy link
Copy Markdown
Owner

@pfeiferj pfeiferj commented Jul 7, 2023

#3 - Add target window options

Uses nui to allow easily configurable target windows.

@PriceHiller
Copy link
Copy Markdown

PriceHiller commented Jul 7, 2023

Has reintroduced the split bug where the float covers the editor after being split. Working to resolve right now as of this message.

Split bug exists purely in the nui window, the fallback window still works as expected.

@PriceHiller
Copy link
Copy Markdown

PriceHiller commented Jul 7, 2023

Resolved here: PriceHiller@6fd32b9

I know there's a split option available now, but the win_type option should really only define the default open behavior. Ideally we don't take over window control from them entirely for splits or whatnot. That can get very annoying when debugging.

@pfeiferj
Copy link
Copy Markdown
Owner Author

pfeiferj commented Jul 8, 2023

Resolved here: treatybreaker@6fd32b9

I know there's a split option available now, but the win_type option should really only define the default open behavior. Ideally we don't take over window control from them entirely for splits or whatnot. That can get very annoying when debugging.

Yeah, i was going to throw the unfocus closes the window thing behind an option. Partially why this is still a draft. There's also some things i need to better consider like how to cleanly deal with splitting the layout for the future highlighting features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants