Skip to content

Conversation

@elvizlai
Copy link
Contributor

@elvizlai elvizlai commented Dec 3, 2025

solving #15

Copilot AI review requested due to automatic review settings December 3, 2025 04:05
@gemini-code-assist
Copy link

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #15 by setting a default min_size parameter for the PostgreSQL connection pool in the synchronous PGMQueue implementation. The change ensures that when min_size is not explicitly provided in the kwargs, it defaults to the value of pool_size.

Key Changes:

  • Added self.kwargs.setdefault("min_size", self.pool_size) before ConnectionPool initialization
  • This ensures the connection pool has a minimum size configuration when not explicitly set

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@elvizlai elvizlai changed the title fix: using pool_size as pg conn min_size if not set fix: using pool_size as pg conn max_size if not set Dec 3, 2025
@ChuckHend ChuckHend mentioned this pull request Dec 6, 2025
@tavallaie
Copy link
Collaborator

@elvizlai, could you please update your PR to use the latest version of pgmq-py?
The tests might pass now.

@tavallaie tavallaie self-requested a review December 21, 2025 14:44
@tavallaie tavallaie merged commit d6318c1 into pgmq:main Dec 21, 2025
3 checks passed
tavallaie added a commit that referenced this pull request Dec 21, 2025
@tavallaie
Copy link
Collaborator

@elvizlai, after merging this PR, I noticed we didn’t add this feature to the async version. Would you like to add it, or should I go ahead and do it myself?

@elvizlai
Copy link
Contributor Author

@elvizlai, after merging this PR, I noticed we didn’t add this feature to the async version. Would you like to add it, or should I go ahead and do it myself?

It seems the async implementation is already using a pool, but I’m not very familiar with the async part, so I’m not sure whether this configuration still needs to be added. If necessary, please feel free to update it directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants