-
Notifications
You must be signed in to change notification settings - Fork 7
fix: using pool_size as pg conn max_size if not set #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses issue #15 by setting a default min_size parameter for the PostgreSQL connection pool in the synchronous PGMQueue implementation. The change ensures that when min_size is not explicitly provided in the kwargs, it defaults to the value of pool_size.
Key Changes:
- Added
self.kwargs.setdefault("min_size", self.pool_size)before ConnectionPool initialization - This ensures the connection pool has a minimum size configuration when not explicitly set
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@elvizlai, could you please update your |
This reverts commit d6318c1.
|
@elvizlai, after merging this PR, I noticed we didn’t add this feature to the async version. Would you like to add it, or should I go ahead and do it myself? |
It seems the async implementation is already using a pool, but I’m not very familiar with the async part, so I’m not sure whether this configuration still needs to be added. If necessary, please feel free to update it directly. |
solving #15