Change broken API to the working one #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created this pull request because the pull request #10, created by @bibajz. This PR has not been active since since August of last year but all the credit still goes to him.
What I changed:
I have tested the change in ubuntu 20.04 and OSX Big Sur and the package and all the models work perfectly with this version
of ujson.
The only thing that needs to be done now is to change the mentions of swapi.co to swapi.dev in the documentation.
I believe this package useful for Star Wars fans like me and many others and should be kept maintained, so if you are no longer interested in maintaining the package I would be more than willing to take over.