Closes #2609: added duplicates example to derive_vars_transposed()

[manciniedoardo]

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

• Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
• Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
• Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
• If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
• Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)
• Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
• Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
• Address any updates needed for vignettes and/or templates
• Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers). A Developer Notes section is available in NEWS.md for tracking developer-facing issues.
• Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
• Address or fix all lintr warnings and errors - lintr::lint_package()
• Run R CMD check locally and address all errors and warnings - devtools::check()
• Link the issue in the Development Section on the right hand side.
• Address all merge conflicts and resolve appropriately
• Pat yourself on the back for a job well done! Much love to your accomplishment!

[github-actions]

Package	Line Rate	Health
admiral	98%	✔
Summary	98% (5316 / 5421)	✔

[bundfussr]

I think we should provide more details in the documentation:

• For id_vars:

  "Variables (excluding by_vars) that uniquely identify each observation in dataset_merge."

  should be updated to

  "Variables (excluding by_vars and key_var) that uniquely identify each observation in dataset_merge.

• The "Details" section should be extended such that the steps (transposing and merging) are explained. It should also mentioned that the function in contrast to other derive_vars_*() functions may add records to the input dataset.

[github-actions]

This Pull Request is stale because it has not been worked on in 15 days.

[manciniedoardo]

@bms63 @bundfussr I have implemented the review comments. Please read through the new @details section to see if anything can be changed/added.

[bms63]

details are looking good to me. just a note in the example

[bms63]

@manciniedoardo Can we specify the argument here and in the other exmaples just so the error message is clear on where it is happening

Thanks again for jumping on this one!!!

[bms63]

I am a happy camper!! 😄

@bundfussr any thoughts or can we merge in?

[bundfussr]

Looks good except one typo.