-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #294 ADRS GCIG vignette #295
Conversation
The rendered version of the vignette is available at https://bundfussr.github.io/admiralonco/294_gcig_vignette/articles/adrs_gcig.html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Olga for working on this vignette. Look good overall few minor suggestion/comments. And we will keep confirmed combined response on later dicsussion.
Hello, I made changes after the first round of comments. |
I've updated the rendered version with the latest changes. |
@kiran-peddamudium , @tomyukn , if you have time, you could have a look at this PR from Olga. She has created a new vignette for ADRS for ovarian cancer studies. (A rendered version is available at https://bundfussr.github.io/admiralonco/294_gcig_vignette/articles/adrs_gcig.html.) |
Hi, I have uploaded a small change to the table that specifies the content in SUPPRS. Last time I commented your remarks as “updated”. Please close your comment if you think it is not more relevant. @vinhn23 in SUPPRS I do not see the change mentioned here: |
Co-authored-by: Stefan Bundfuss <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think few minor comments as we are close. I also suggested to totally remove the combined confirmed response as not clear from the guidance, we will dig more next year and finalize as needed.
@bundfussr @vinhn23 I get errors when running |
@starosto , I did run them in my environment. Both passed. |
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.main
.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()
The following line requests to update the man pages by the "Man Pages" workflow.
/roxygenize