Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #294 ADRS GCIG vignette #295

Merged
merged 15 commits into from
Jan 24, 2025
Merged

Closes #294 ADRS GCIG vignette #295

merged 15 commits into from
Jan 24, 2025

Conversation

starosto
Copy link
Collaborator

@starosto starosto commented Nov 13, 2024

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update). Then the issue is closed automatically once it is merged to main.
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue so that it closes after successful merging.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

The following line requests to update the man pages by the "Man Pages" workflow.

/roxygenize

Copy link

github-actions bot commented Nov 13, 2024

Code Coverage

Package Line Rate Health
admiralonco 97%
Summary 97% (531 / 547)

@bundfussr
Copy link
Collaborator

The rendered version of the vignette is available at https://bundfussr.github.io/admiralonco/294_gcig_vignette/articles/adrs_gcig.html.

Copy link
Collaborator

@amitjaingsk amitjaingsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Olga for working on this vignette. Look good overall few minor suggestion/comments. And we will keep confirmed combined response on later dicsussion.

@starosto
Copy link
Collaborator Author

Hello, I made changes after the first round of comments.

@bundfussr bundfussr linked an issue Nov 25, 2024 that may be closed by this pull request
@bundfussr
Copy link
Collaborator

The rendered version of the vignette is available at https://bundfussr.github.io/admiralonco/294_gcig_vignette/articles/adrs_gcig.html.

I've updated the rendered version with the latest changes.

@bundfussr
Copy link
Collaborator

@kiran-peddamudium , @tomyukn , if you have time, you could have a look at this PR from Olga. She has created a new vignette for ADRS for ovarian cancer studies. (A rendered version is available at https://bundfussr.github.io/admiralonco/294_gcig_vignette/articles/adrs_gcig.html.)

@starosto
Copy link
Collaborator Author

starosto commented Dec 4, 2024

Hi, I have uploaded a small change to the table that specifies the content in SUPPRS. Last time I commented your remarks as “updated”. Please close your comment if you think it is not more relevant.

@vinhn23 in SUPPRS I do not see the change mentioned here:
#295 (comment)

Copy link
Collaborator

@amitjaingsk amitjaingsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think few minor comments as we are close. I also suggested to totally remove the combined confirmed response as not clear from the guidance, we will dig more next year and finalize as needed.

@starosto starosto requested a review from amitjaingsk January 23, 2025 16:39
@starosto starosto requested a review from bundfussr January 23, 2025 16:39
@starosto
Copy link
Collaborator Author

@bundfussr @vinhn23 I get errors when running pkgdown::build_site() and devtools::check() from the task list. This may be because I can't install some versions of the packages (for example {pharmaversesdtm} the newest v1.2.0). Can you please run these checks in your R environment?

@bundfussr bundfussr merged commit 5e22895 into main Jan 24, 2025
15 checks passed
@bundfussr bundfussr deleted the 294_gcig_vignette branch January 24, 2025 13:46
@bundfussr
Copy link
Collaborator

@bundfussr @vinhn23 I get errors when running pkgdown::build_site() and devtools::check() from the task list. This may be because I can't install some versions of the packages (for example {pharmaversesdtm} the newest v1.2.0). Can you please run these checks in your R environment?

@starosto , I did run them in my environment. Both passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: ADRS vignette for ovarian cancer
4 participants