-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3d stable #54
3d stable #54
Conversation
AWESOME! Two requests before I merge this in:
Can we not deal with these issues of changing the method-inheritance system in this pull-request? (ie, x() and y() methods). It's a valid complaint, but let's keep to the existing pattern (with all it warts) for this pull, and deal with how we do method inheritance in a separate issue, so we can deal with it in a complete way for all methods at once. See comments on #53. |
|
||
// Load into DOMDOcument | ||
libxml_use_internal_errors(true); | ||
$xmlobj = new DOMDocument('1.0', 'UTF-8'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
i have merging the change, i think it's ok. i have put methods x() y() etc... to geometry, but non abstract. this make no change. |
Thanks! I'm going to do a little bit of clean-up on this. I also want to do some performance testing and tweaking on the WKB adapter before merging into master. |
Great, i now work on a Gml adapters. |
hi, it's me again !
add:
remove:
Testing polygon.wkb fail, i think it's an ewkb