Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3d stable #54

Merged
merged 3 commits into from
Sep 8, 2012
Merged

3d stable #54

merged 3 commits into from
Sep 8, 2012

Conversation

mkdgs
Copy link

@mkdgs mkdgs commented Sep 5, 2012

hi, it's me again !

add:

  • Z for Gpx
  • Z for Wkb (wkb packing was rewritten)
  • Z for Ewkt (with regex)
  • fix namespace problem for georss (and use xpath)

remove:

  • point method from geometry

Testing polygon.wkb fail, i think it's an ewkb

@phayes
Copy link
Owner

phayes commented Sep 5, 2012

AWESOME!

Two requests before I merge this in:

  1. Can you merge in upstream so that there are no merge conflicts?
  2. Repeating myself from just-posted comments on pull-request Better all-round 3D support #53:

Can we not deal with these issues of changing the method-inheritance system in this pull-request? (ie, x() and y() methods). It's a valid complaint, but let's keep to the existing pattern (with all it warts) for this pull, and deal with how we do method inheritance in a separate issue, so we can deal with it in a complete way for all methods at once. See comments on #53.


// Load into DOMDOcument
libxml_use_internal_errors(true);
$xmlobj = new DOMDocument('1.0', 'UTF-8');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

@mkdgs
Copy link
Author

mkdgs commented Sep 5, 2012

i have merging the change, i think it's ok.
i have not very well tested, the test seems to stucked in a infinite loop... distance calculation take a while ?

i have put methods x() y() etc... to geometry, but non abstract. this make no change.

phayes added a commit that referenced this pull request Sep 8, 2012
@phayes phayes merged commit 940d9d8 into phayes:3d Sep 8, 2012
@phayes
Copy link
Owner

phayes commented Sep 8, 2012

Thanks! I'm going to do a little bit of clean-up on this. I also want to do some performance testing and tweaking on the WKB adapter before merging into master.

@mkdgs
Copy link
Author

mkdgs commented Sep 14, 2012

Great, i now work on a Gml adapters.
also i have started to refactor the class for getting out all unnecessary abstract methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants