Fixes Scroll instantly to next result in Find mode #4661 #4677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navigating between search results in find mode now happens instantly to match native Browser behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigating between search results in find mode now happens instantly to match native Browser behavior.
Description
This fixes #4661.
As requested by #4661 (comment) the fix now uses instant scroll behavior for find mode hard-coded instead of respecting the Vimium
smoothScrollSetting. That way it will behave like the native browser search in Chromium / Firefox based browsers.This is blocked by #4676 as find mode on the current master is broken.
Edit:
I successfully tested this based on the current master plus the suggested fix from #4676 - which is not part of this PR - in: