Skip to content

Expose hud text via data-text attribute #4758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expose hud text via data-text attribute #4758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pages/hud_page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ export const handlers = {
show(data) {
const el = document.querySelector("#hud");
el.textContent = data.text;
el.dataset.text = data.text;
el.classList.add("vimium-ui-component-visible");
el.classList.remove("vimium-ui-component-hidden");
el.classList.remove("hud-find");
Expand All @@ -100,6 +101,7 @@ export const handlers = {
// We get a flicker when the HUD later becomes visible again (with new text) unless we reset its
// contents here.
el.textContent = "";
delete el.dataset.text;
el.classList.add("vimium-ui-component-hidden");
el.classList.remove("vimium-ui-component-visible");
},
Expand Down