Skip to content

Commit

Permalink
tests: object: decrease number of concurrent cache accesses
Browse files Browse the repository at this point in the history
In our test case object::cache::fast_thread_rush, we're creating 100
concurrent threads opening a repository and reading objects from it.
This test actually fails on ARM32 with an out-of-memory error, which
isn't entirely unexpected.

Work around the issue by halving the number of threads.
  • Loading branch information
pks-t committed Feb 18, 2020
1 parent 01a8340 commit eaa70c6
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tests/object/cache.c
Original file line number Diff line number Diff line change
Expand Up @@ -244,15 +244,15 @@ static void *cache_quick(void *arg)

void test_object_cache__fast_thread_rush(void)
{
int try, th, data[THREADCOUNT*2];
int try, th, data[THREADCOUNT];
#ifdef GIT_THREADS
git_thread t[THREADCOUNT*2];
git_thread t[THREADCOUNT];
#endif

for (try = 0; try < REPEAT; ++try) {
cl_git_pass(git_repository_open(&g_repo, cl_fixture("testrepo.git")));

for (th = 0; th < THREADCOUNT*2; ++th) {
for (th = 0; th < THREADCOUNT; ++th) {
data[th] = th;
#ifdef GIT_THREADS
cl_git_pass(
Expand All @@ -263,7 +263,7 @@ void test_object_cache__fast_thread_rush(void)
}

#ifdef GIT_THREADS
for (th = 0; th < THREADCOUNT*2; ++th) {
for (th = 0; th < THREADCOUNT; ++th) {
void *rval;
cl_git_pass(git_thread_join(&t[th], &rval));
cl_assert_equal_i(th, *((int *)rval));
Expand Down

0 comments on commit eaa70c6

Please sign in to comment.