feat: add TransformAssetUrls options

[ErKeLost]

close #63

@phoenix-ru PTAL

I have temporarily solved the problem of processing assets url paths in the development environment. Next, I will sort out all the attribute-related code, which can also help me better understand the code. Next, I will realize the splitting of the overall attribute structure.

[phoenix-ru]

fervid_core has access to fxhash, can you use it instead?

[phoenix-ru]

upd: As said in other comments, transform_asset_urls should really be in the fervid_transform, please revert this change

I don't really like the idea of forcing transform_asset_urls into the constructor.

Maybe the constructor should be renamed then to be more intuitive?

[phoenix-ru]

I think converting from std::collections::HashMap to fxhash::FxHashMap should be rather trivial

[phoenix-ru]

You should prefer using structs.rs for fervid_napi to keep configuration close as of now. Fervid is already huge and having lots of small files does not help with navigation 🙁

[phoenix-ru]

I think this needs to be non-option, because it is fervid_core.

The assumption is: fervid_core gets "clean" structures into it. Otherwise every crate which depends on it will need to unwrap with some kind of default values. fervid_core can provide defaults as you already did.

Suggested change

	pub tags: Option<AssetURLTagConfig>,
	pub tags: AssetURLTagConfig,

[phoenix-ru]

Same comment here, do not wrap the option in an enum, use AssetURLOptions directly.

You can do wrapping in the "external" crates, such as fervid_napi, fervid_wasm and fervid_farmfe because there you need freedom

Suggested change

	#[derive(Debug, Clone)]
	pub enum TransformAssetUrls {
	// TODO
	// export interface AssetURLTagConfig {
	// [name: string]: string[]
	// }
	Boolean(bool),
	Options(AssetURLOptions),
	}

[phoenix-ru]

You can in theory accept an enum Options, Boolean here, but let's not do it now and stay at your current code

[phoenix-ru]

Suggested change

	CoreTransformAssetUrls::Options(CoreAssetURLOptions {
	base: value.base,
	include_absolute: value.include_absolute.unwrap_or(false),
	tags: value.tags,
	})
	CoreAssetURLOptions {
	base: value.base,
	include_absolute: value.include_absolute.unwrap_or(false),
	tags: value.tags,
	}

[phoenix-ru]

This looks very much like a template transform phase instead of a codegen phase. You also asked a question about where to put the asset url code so that it fits.

Here's the general concept:

• transform phase does AST manipulations, for both <script> and <template>. It means it can change anything on the AST, including src: '~/foo/bar' -> src: _imported. You would do this by changing from AttributeOrBinding::RegularAttribute into AttributeOrBinding::VBind (what you are trying to do, essentially). With the change, codegen will now correctly generate the Expr you put into VBind instead of a string for RegularAttribute.
• codegen phase does not modify the AST, but instead builds its own Module:

  fervid/crates/fervid_codegen/src/control_flow/sfc.rs

  Lines 46 to 53 in 7403daf

  	pub fn generate_module(
  	&mut self,
  	template_expr: Option<Expr>,
  	mut script: Module,
  	mut sfc_export_obj: ObjectLit,
  	mut synthetic_setup_fn: Option<Box<Function>>,
  	gen_default_as: Option<&str>,
  	) -> Module {

So the easiest for you is to implement another transform for asset URLs inside fervid_transform.

I am also very sorry if the structure is a bit messy, I am ideating about the new fervid_transform structure for quite a while now, but this part is very untrivial. @vue/compiler-sfc does a lot of strange things which Rust simply does not allow, for example as any casts or having a parentStack.

[phoenix-ru]

This 100% belongs into its own transform

[phoenix-ru]

@ErKeLost Here is an example of a remap from RegularAttribute into VBind:

fervid/crates/fervid_transform/src/template/ast_transform.rs

Lines 536 to 546 in 7403daf

	let _ = std::mem::replace(
	attr,
	AttributeOrBinding::VBind(VBindDirective {
	argument: Some(StrOrExpr::Str(fervid_atom!("ref"))),
	value: Box::new(Expr::Ident(value.into_ident_spanned(span))),
	is_camel: false,
	is_prop: false,
	is_attr: false,
	span,
	}),
	);

If you need any more assistance, do not hesitate to write 🙂

[ErKeLost]

@ErKeLost Here is an example of a remap from RegularAttribute into VBind:以下是从 RegularAttribute 重新映射到 VBind 的示例：

fervid/crates/fervid_transform/src/template/ast_transform.rs

Lines 536 to 546 in 7403daf

	let _ = std::mem::replace(
	attr,
	AttributeOrBinding::VBind(VBindDirective {
	argument: Some(StrOrExpr::Str(fervid_atom!("ref"))),
	value: Box::new(Expr::Ident(value.into_ident_spanned(span))),
	is_camel: false,
	is_prop: false,
	is_attr: false,
	span,
	}),
	);

If you need any more assistance, do not hesitate to write 🙂如果您需要更多帮助，请随时写信 🙂

Thanks for your review, I will try to modify the code according to your method. You suggested that I should make the modification attributes in transform instead of codegen, right? Let me look at the code in the transform first