Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the Long-Poll Transport Limitations #6057

Merged
merged 3 commits into from
Jan 26, 2025

Conversation

probably-not
Copy link
Contributor

Currently, Phoenix will automatically enable a long-poll Socket implementation and LiveView will fallback to long-polling automatically, in order to avoid issues with network conditions not allowing WebSockets. This comes with a major undocumented footgun - Long-Polling requires that either all requests go to the same machine (stickiness), or that nodes in a cluster can communicate.

This documents the footgun and warns the user, along with explaining why this happens.

probably-not and others added 2 commits January 22, 2025 14:31
According to the suggestion by @josevalim

Co-authored-by: José Valim <[email protected]>
Move the section to below the Putting it all together section according to suggestion by @josevalim
@probably-not
Copy link
Contributor Author

Hey All, any word on when we can get this in? It's already been approved...

@josevalim
Copy link
Member

Once another maintainer takes a look. No worries though, we will ping you if something is needed :)

@probably-not
Copy link
Contributor Author

Thanks @josevalim 🙏

@SteffenDE SteffenDE merged commit 05a6299 into phoenixframework:main Jan 26, 2025
5 checks passed
@SteffenDE
Copy link
Contributor

Thank you! @probably-not 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants