Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align sqlite migration code with comment #6101

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

rmand97
Copy link
Contributor

@rmand97 rmand97 commented Feb 19, 2025

fixes #5945

The wording of the code comment implies the opposite of what the function actually does.
I aligned the code with the comment. Can also do it the other way around if needed.

@rmand97 rmand97 changed the title align sqlite migration code with code comment align sqlite migration code with comment Feb 19, 2025
@SteffenDE SteffenDE requested a review from Gazler February 20, 2025 15:51
@Gazler Gazler merged commit 2001cde into phoenixframework:main Feb 20, 2025
5 checks passed
@Gazler
Copy link
Member

Gazler commented Feb 20, 2025

Thanks <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlite generated code - wrong wording?
2 participants