Document how to use scopes in JS commands for DOM selectors #3638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteffenDE
reviewed
Jan 17, 2025
| * `{:closest, "selector"}` To target the closest element within the interacted | ||
| element. | ||
|
|
||
| For example, if building a dropdown component, the button could use the `:inner` |
There was a problem hiding this comment.
Note that with this example, if there was any kind of nested dropdown, the nested ones would be targeted as well. For a dropdown probably not that relevant, but when doing dialogs it could be problem.
There was a problem hiding this comment.
That's a good point, the same rule applies when passing a string as a selector, so perhaps closest is the outlier here?
There was a problem hiding this comment.
Yeah, maybe it would make sense to mention this. The default and inner variant target multiple elements (-> document/element.querySelectorAll) and closest stops when it finds the first match (-> element.closest). As this is "Phoenix.LiveView.JS", we could even link to the docs for those?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.