proof of concept: alternative implementation of put_session #3672
+431
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proof of concept for session manipulation from LiveViews. It works by pushing an encoded token to the client, which in turn performs a POST request that updates the session cookie.
SteffenDE
force-pushed
the
sd-put-session-cookie
branch
from
6e00733 to
aa423ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #3671
Does NOT use an extra HTTP request.
sequenceDiagram participant HTTP participant LiveView participant Client LiveView->>LiveView: Call put_session alt Dead Render HTTP->>Client: Store values in conn session else LiveView Connected LiveView->>Client: Send diff with updated data-phx-session and token Client->>Client: Set token as special cookie (not HTTP-only) end Note over Client,HTTP: On next dead render (redirect or refresh) Client->>HTTP: Request contains special cookie HTTP->>Client: Apply extra session values from cookie to session