phpdoc return type for ServerRequestInterface::getUploadedFiles() #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For better IDE autocompletion I suggest replace return type for `ServerRequestInterface::getUploadedFiles()` from simple `array` to `UploadedFileInterface[]`
|
This is wrong, |
| @@ -131,7 +131,7 @@ public function withQueryParams(array $query); | |||
| * These values MAY be prepared from $_FILES or the message body during | |||
| * instantiation, or MAY be injected via withUploadedFiles(). | |||
| * | |||
| * @return array An array tree of UploadedFileInterface instances; an empty | |||
| * @return UploadedFileInterface[] An array tree of UploadedFileInterface instances; an empty | |||
There was a problem hiding this comment.
wrong type:
an empty array MUST be returned if no data is present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better IDE autocompletion I suggest replace return type for
ServerRequestInterface::getUploadedFiles()from simplearraytoUploadedFileInterface[]