Merge pull request #299 from pedro-mendonca/php-8-3-test

Support for PHP >= 8.2
php-gettext · Jul 24, 2024 · 73c501a · 73c501a
2 parents 5e7551f + b8bc186
commit 73c501a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/Generator/MoGenerator.php b/src/Generator/MoGenerator.php
@@ -45,7 +45,7 @@ public function generateString(Translations $translations): string
             $messages[$originalString] = $translation;
         }
 
-        ksort($messages);
+        ksort($messages, SORT_STRING);
         $numEntries = count($messages);
         $originalsTable = '';
         $translationsTable = '';

diff --git a/tests/MoGeneratorTest.php b/tests/MoGeneratorTest.php
@@ -36,6 +36,10 @@ public function testMoGenerator()
         $translation->translate('Comentario deshabilitado');
         $translations->add($translation);
 
+        $translation = Translation::create(null, '15');
+        $translation->translate('15');
+        $translations->add($translation);
+
         $translation = Translation::create(null, '123456');
         $translation->translate('12345');
         $translations->add($translation);
@@ -47,7 +51,7 @@ public function testMoGenerator()
 
         $result = $loader->loadString($mo);
 
-        $this->assertCount(3, $result);
+        $this->assertCount(4, $result);
         $this->assertCount(5, $result->getHeaders());
     }
 }
diff --git a/tests/assets/mo-generator-result.mo b/tests/assets/mo-generator-result.mo