Skip to content

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Sep 4, 2024

Otherwise optionals don't work.

See #66

Otherwise optionals don't work.

See php-http#66
@ruudk ruudk mentioned this pull request Sep 4, 2024
@dbu dbu merged commit 825153b into php-http:1.x Sep 4, 2024
13 checks passed
@dbu
Copy link
Contributor

dbu commented Sep 4, 2024

we should have phpstan as a build step here, then we would have noticed 😅

something like https://github.com/php-http/httplug/blob/87779285e14780b0a85209bfed8abd9d5fe0322e/.github/workflows/static.yml#L10 if you are motivated to try that ;-)

@ruudk ruudk deleted the patch-1 branch September 4, 2024 13:27
@prakash559
Copy link

Error coming up:
vendor/php-http/multipart-stream-builder
err: has uncommitted changes

@ruudk
Copy link
Contributor Author

ruudk commented Sep 6, 2024

@prakash559 That's on your side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants