Skip to content

Adding format=symfony for imports #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding format=symfony for imports #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd7a0a4
Discouraging the use of non-default index
Dec 5, 2023
a80a90e
Import API should receive format=symfony, as per export
Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ If you have one Loco project per domain you may configure the bundle like this:
```yaml
# /app/config/config.yml
translation_adapter_loco:
index_parameter: 'id' # 'text' or 'name'. Leave blank for "auto" See https://localise.biz/api/docs/export/exportlocale
index_parameter: 'id' # recommended for Symfony XLIFF See https://localise.biz/help/formats/importing/xliff#symfony
projects:
messages:
api_key: 'foobar'
Expand All @@ -43,7 +43,7 @@ If you just doing one project and have tags for all your translation domains you
```yaml
# /app/config/config.yml
translation_adapter_loco:
index_parameter: 'id' # 'text' or 'name'. Leave blank for "auto" See https://localise.biz/api/docs/export/exportlocale
index_parameter: 'id' # recommended for Symfony XLIFF See https://localise.biz/help/formats/importing/xliff#symfony
projects:
acme:
api_key: 'foobar'
Expand Down
1 change: 1 addition & 0 deletions src/Loco.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ public function import(MessageCatalogueInterface $catalogue, array $options = []
'locale' => $locale,
'async' => 1,
'index' => $project->getIndexParameter(),
'format' => 'symfony',
];

if ($project->isMultiDomain()) {
Expand Down