Skip to content

Conversation

@AllenJB
Copy link
Contributor

@AllenJB AllenJB commented May 3, 2025

Improved the documentation of strcmp to make it clear it's not locale aware and direct to alternatives.

Improved the strcmp see also list:

  • Broke the list up into clear categories
  • Add the string similarity functions
  • Removed substr because I don't think it belongs here

Improved the see also lists for the the string similarity functions by cross-linking them all.

AllenJB added 3 commits May 3, 2025 15:02
…functions (strcoll and Collator::compare) where appropriate;

Add the "similarity" functions to seealso
Removed substr from seealso (why is it here?)
AllenJB and others added 2 commits June 7, 2025 09:51
…functions (strcoll and Collator::compare) where appropriate
@AllenJB AllenJB requested a review from kamil-tekiela July 19, 2025 17:09
@Crell
Copy link
Contributor

Crell commented Oct 3, 2025

Thanks!

@Crell Crell merged commit 873f4a3 into php:master Oct 3, 2025
2 checks passed
@AllenJB AllenJB deleted the strcmp_seealso branch October 11, 2025 15:53
Crell pushed a commit to Crell/doc-en that referenced this pull request Dec 15, 2025
* strcmp: Improve behavior description and direct users to alternative functions (strcoll and Collator::compare) where appropriate;
Add the "similarity" functions to seealso
Removed substr from seealso (why is it here?)

* Cross-link all the string similarity functions

* Trailing whitespace removal

* Update reference/strings/functions/strcmp.xml

Co-authored-by: Kamil Tekiela <[email protected]>

* strcmp: Improve behavior description and direct users to alternative functions (strcoll and Collator::compare) where appropriate

---------

Co-authored-by: Kamil Tekiela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants