Fix FQN class, method, property and constant linking #185
Conversation
haszi
force-pushed
the
Fix-FQN-Class-and-method-links
branch
from
2991519 to
80c2cd3
Compare
|
Added a method for normalizing the FQNs. As it was trivial, the same fix was applied to constants and properties. |
haszi
changed the title
alfsb
left a comment
alfsb
left a comment
There was a problem hiding this comment.
This is already merged, I know. Only to comment what can make te code easier in future.
| } | ||
|
|
||
| private function convertConstantNameToId(string $constantName): string { | ||
| $tempLinkValue = str_replace( |
There was a problem hiding this comment.
In a future version, move all transformations inside the normalize function (trim, replace), to make understanding the code easier.
| return $value; | ||
| } | ||
|
|
||
| $tempLinkValue = str_replace( |
There was a problem hiding this comment.
The replace list here differs from other point. Maybe there is necessary two normalize functions, or if the difference is accidental, to test what list of substitutions is the correct.
| } | ||
|
|
||
| public function format_type_text($type, $tagname) { | ||
| $t = strtr(strtolower($type), ["_" => "-", "\\" => "-"]); |
There was a problem hiding this comment.
Note how these substations lists are copied everywhere.
|
|
||
| public function format_classname_text($value, $tag) { | ||
| if (($filename = $this->getClassnameLink(strtolower($value))) !== null && $this->cchunk["class_name_ref"] !== strtolower($value)) { | ||
| if (($filename = $this->getClassnameLink($this->normalizeFQN($value))) !== null && $this->cchunk["class_name_ref"] !== strtolower($value)) { |
There was a problem hiding this comment.
This is somewhat unrelated, but in a future version, first test if getClassnameLink() with fails with raw string, and then test again with plain \trim(). In this case, generate the link as usual but generate an warning, as this a source error (unexpected whitespace around type/constante/etc tags).
3 participants
Minimal fix for FQN class and method/function linking not working. Closes GH-170.