Define undefined properties and variables #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Jan 5, 2025
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
MSTM, but I wonder if we shouldn't be removing some of the packages/styles (I have no idea why PEAR would be used anymore)
Contributor
Author
This would make sense. I'm not sure whether the libraries the PDF formats (Haru) and the format highlighters (GeSHi) are based on are still being maintained but those could probably be dropped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define undefined properties and variables.
I'm planning on opening one or more PRs that would address some of the smaller issues found with static analysis before I try to make larger changes (such as adding parameter and return types). If anyone has any objections to this, please let me know.