Improve portability of the test suite #244
Open
+567
−565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not assume details regarding the error locations which are shown in the messages, since this makes the tests brittle regarding minor modifications, and won't work for systems which do not use a slash as `DIRECTORY_SEPARATOR`. This is also in line with bless-tests.php.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is now, the test suite is barely useful on Windows; besides the three tests that are currently failing on Travis, additional 44 are failing there. This is mostly due to hard-coded directory separators, but also a few other reasons. These changes brings that down to four additional failures.