[RFC] FILTER_THROW_ON_FAILURE #18896
Conversation
DanielEScherzer
changed the title
DanielEScherzer
force-pushed
the
filter-throw-on-failure
branch
from
8c5abca to
86969e5
Compare
DanielEScherzer
force-pushed
the
filter-throw-on-failure
branch
from
86969e5 to
10dab9e
Compare
|
LGTM fwiw. (I don't have access use the actual github review form on php-src, but it lgtm.) |
ext/filter/filter.c
Outdated
| zend_throw_exception_ex( | ||
| php_filter_failed_exception_ce, | ||
| 0, | ||
| "filter validation failed: filter %s not satisfied by %s", |
There was a problem hiding this comment.
Would it make sense to use ' around the %s's? In the error message, you can now end up with a phrase like:
filter validation failed: filter %s not satisfied by elephpants
Which reads as a joke... as it's unclear whether elephpants are the variable contents that the filter is operating on.
There was a problem hiding this comment.
Done for this one, since the second %s is a string version of the value
| zend_throw_exception_ex( | ||
| php_filter_failed_exception_ce, | ||
| 0, | ||
| "filter validation failed: not an array (got %s)", |
There was a problem hiding this comment.
Here %s is not just the string value, it can also be "true"/"false"/"null" for true/false/null, or a class name; I think quotes here would be more confusing, and the name is clearly everything after the "got"
There was a problem hiding this comment.
maybe
Z_TYPE_P(value) == IS_STRING ?
"filter validation failed: not an array (got '%s')"
: "filter validation failed: not an array (got %s)"
DanielEScherzer
force-pushed
the
filter-throw-on-failure
branch
from
5e658f7 to
e16eb44
Compare
https://wiki.php.net/rfc/filter_throw_on_failure