ext/posix: posix_kill() process_id range check. #18944
Open
+63
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
before going into a pid_t handling "killing spree" all over the extension, let me know if this is something wishable. |
devnexen
force-pushed
the
posix_oflow_nonposix
branch
from
996cc69 to
e9402c6
Compare
|
cc @Girgias |
|
I think this makes sense, as anything outside of this range seems to point to a bug |
devnexen
force-pushed
the
posix_oflow_nonposix
branch
from
e9402c6 to
a84a097
Compare
pid_t is, for the most part, represented by a signed int, by overflowing it, we end up being in the -1 case which affect all accessible processes.
devnexen
force-pushed
the
posix_oflow_nonposix
branch
from
a84a097 to
c540a26
Compare
|
What actually happens on -2 at the moment? |
|
hmmm looking at it now, negative numbers < -1 might be relevant cases, they normally aim for process groups in this case e.g. -2 -> process group 2 but will have a look later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pid_t is, for the most part, represented by a signed int, by overflowing it, we end up being in the -1 case which affect all accessible processes.