Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some times ago I added a few
opcache.preload_user
tests that need aTEST_NON_ROOT_USER
variable, but I never defined this variable in CI (these tests also need to run as root, but there were no CI job that ran as root at the time).Here I fix this by setting the variable in the ALPINE nightly job, which runs as root.
Also set
ASAN_OPTIONS=detect_leaks=0
for these tests, because the preload child process doesn't exit cleanly:php-src/ext/opcache/ZendAccelerator.c
Line 5059 in 6141594
Targeting 8.4 because .github/actions/test-alpine does not exist in earlier branches.