Skip to content

Rename poorly named tests in Zend/tests #19332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025

Conversation

alexandre-daubois
Copy link
Contributor

No description provided.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if some should be moved into a folder (e.g. the closure ones into the tests/closures/ folder

@alexandre-daubois
Copy link
Contributor Author

alexandre-daubois commented Jul 31, 2025

Wonder if some should be moved into a folder

I agree. I moved some of the tests I renamed to directories when relevant. While at it, I definitely saw more files to move. Ultimately, everything should be in a directory I guess? I can try to propose a follow-up PR if the answer is yes.

@Girgias
Copy link
Member

Girgias commented Jul 31, 2025

Wonder if some should be moved into a folder

I agree. I moved some of the tests I renamed to directories when relevant. While at it, I definitely saw more files to move. Ultimately, everything should be in a directory I guess? I can try to propose a follow-up PR if the answer is yes.

@DanielEScherzer did the bulk of the work moving files into directories, but ideally yes everything relating to a feature would be in the relevant directory so if some refactoring is done one doesn't need to run the whole Zend/tests folder at once :)

Copy link
Member

@DanielEScherzer DanielEScherzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its probably going to bug me that the numbered tests (Zend/tests/%d.phpt) are now no longer consecutive due to gaps, but thats fine for now.

@Girgias Girgias merged commit e43074a into php:master Jul 31, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants