Add support for replaying warnings in opcache #5600
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dstogov What do you think about this? If necessary, I could also put this feature behind an ini setting. (The new file cache CI job will need some more work, to fix some segfaults and skip some tests.) |
|
I don't see a big value, but I also don't see anything bad. |
nikic
force-pushed
the
opcache-replay-warnings
branch
2 times, most recently
from
4c7a025 to
059a140
Compare
Less ini option juggling when testing file cache.
Use run-tests flags in azure job
nikic
force-pushed
the
opcache-replay-warnings
branch
from
059a140 to
d56128b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect warnings when the file is compiled and then replay them when it is included again. This fixes https://bugs.php.net/bug.php?id=76535.
With this, we should also be able to set up a job for testing file cache.