Bugfix 80097: Have ReflectionAttribute implement Reflector, __toString

[beberlei]

https://bugs.php.net/bug.php?id=80097

Questions:

• Is this the right representation? Arguments could potentially be very complex, I don't think they should be rendered?
• what about attributes on all reflectors, should we print them as well? so when you echo a ReflectionFunction with an attribute for example.
• What about php -r*?

[krakjoe]

@beberlei this looks like an easy win, can you move this forward please ?

(nobody complained, ship it, imo)

[nikic]

I think I complained at the time, but I changed my mind and this looks fine :)

[nikic]

https://bugs.php.net/bug.php?id=80097

Questions:

* Is this the right representation? Arguments could potentially be very complex, I don't think they should be rendered?

I think it would be good to include arguments. Maybe you can use the format_default_value logic to print a compact representation?

* what about attributes on all reflectors, should we print them as well? so when you echo a ReflectionFunction with an attribute for example.

I think that would make sense, yes.

* What about `php -r*`?

Don't think that's a concern, because attribute uses (which is what ReflectionAttribute is about) aren't distinct symbols. This is also kind of covered by the previous point.

[ramsey]

@beberlei, this looks like it's waiting on some feedback from you before I can merge it in.

[beberlei]

Ah will check in the next days

[beberlei]

I'd like this to get merged to have Reflector::__toString support on ReflectionAttribute for now, and I will work on support for attributes on each other reflector in another PR in the next weeks when I have some time.

[nikic]

This looks okay, but I wonder if it would make sense to print it as

Attribute [ Baz('foo', 1234) ]

or even

#[Baz('foo', 1234)]

instead?

Maybe this doesn't compose well when included in other reflection output though.

[beberlei]

Yes, the idea was that this gets its own _attribute_string at some point and nests into the existing reflection structures that look this way.

[derrabus]

Thank you!